-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Gh issue filter #215
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/app/gh-finder/page.jsx
Outdated
} | ||
onClick={() => setSelected(2)} | ||
> | ||
Github | ||
</button> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Insert it on a separate line
src/app/gh-finder/page.jsx
Outdated
@@ -39,25 +61,47 @@ export default function GhFinder() { | |||
// Return true if luminance is less than 0.5 (considered dark) | |||
return luminance < 0.5; | |||
} | |||
|
|||
const issuesToDisplay = filteredIssue.length > 0 ? filteredIssue : data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this
src/app/gh-finder/modal.jsx
Outdated
aria-labelledby="modal-modal-title" | ||
aria-describedby="modal-modal-description" | ||
> | ||
<Box sx={style} className="bg-gray-800"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it light on light mode
src/app/gh-finder/modal.jsx
Outdated
display: "flex", | ||
}; | ||
|
||
export default function BasicModal({ selectedLabels, setSelectedLabels }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integrate these :
- Search
- Is assigned
- Is fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bashamega, I don't understand the use of "isFork is". Is it for displaying the forks in number or else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bashamega, I don't understand the use of "isFork is". Is it for displaying the forks in number or else?
I mean is there a fork opened for the issue. If someone have opened a fork for the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like 0 fork, 2k fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like 0 fork, 2k fork?
No.
I mean if the issue has a fork to close it. So if for this repo if i checked it will hide issue #215 because you have opened a pr that will close it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i try to search it just disappears. And keeps loading. |
For getting Linked Pr info I have added another fetch, where it map into data and again fetches the issues timeline details. So GitHub api limit gets exceeded. |
` // New function to fetch PRs linked to issues const fetchPRsForIssue = async (issue) => {
};` |
` useEffect(() => {
}, [data]); |
@amanr-dev I mean just use the built-in filter function for the search. It will just search the current table. Also for the request limit you need to add error handling to it. |
Yes, i already use filter method for getting search from Data state, but due to the API limit exceeding it shows loading. |
90% of the work is done and just doing small fixes |
@Bashamega , can you review it |
Great job! |
closes #158