Change the icon for toggle theme #190

HarshitT00 · 2024-07-22T07:00:46Z

This pull request addresses issue #173 "The changer icons"

Changes made:

Added moon icon for dark theme
Added sun icon for light theme
Implemented these icons in the theme changer toggle

This enhancement improves the user interface by providing visual cues for the current theme and the action of changing themes.

Closes #173

vercel · 2024-07-22T07:00:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-dev-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 22, 2024 10:33am

HarshitT00 · 2024-07-22T07:10:55Z

I have made a different folder but again it giving error can you tell me the error

Bashamega · 2024-07-22T07:27:29Z

Hello:)

This is the problem:

Error: Default export is missing in "/vercel/path0/src/app/components/icon.jsx"
    at 15875 (/vercel/path0/.next/server/app/components/icon/route.js:1:1642)
    at t (/vercel/path0/.next/server/webpack-runtime.js:1:128)
    at n (/vercel/path0/.next/server/app/components/icon/route.js:1:2731)
    at /vercel/path0/.next/server/app/components/icon/route.js:1:2762
    at t.X (/vercel/path0/.next/server/webpack-runtime.js:1:1206)
    at /vercel/path0/.next/server/app/components/icon/route.js:1:2744
    at Object.<anonymous> (/vercel/path0/.next/server/app/components/icon/route.js:1:2790)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1208:32)
> Build error occurred
Error: Failed to collect page data for /components/icon
    at /vercel/path0/node_modules/next/dist/build/utils.js:1268:15
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  type: 'Error'

Also please don't create a new pr just push a new commit.

HarshitT00 · 2024-07-22T07:46:03Z

It running well in my local but I don't know why it failing here.

src/app/components/icon.jsx

Bashamega · 2024-07-22T08:49:15Z

@amanr-dev Can you help @HarshitT00 . I am busy with other things

dipanshurdev · 2024-07-22T10:02:31Z

@amanr-dev Can you help @HarshitT00 . I am busy with other things

Hi @Bashamega, Can you share with me the Error message on Vercel Deployment has failed

Bashamega · 2024-07-22T10:05:55Z

Hi @Bashamega, Can you share with me the Error message on Vercel Deployment has failed

Okay,


[11:46:28.353] Installing dependencies...
[11:46:36.575] npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
[11:46:39.082] npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
[11:46:39.742] npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
[11:46:41.161] npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
[11:46:41.209] npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
[11:46:41.465] npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
[11:47:01.155] 
[11:47:01.156] added 630 packages in 33s
[11:47:01.156] 
[11:47:01.156] 158 packages are looking for funding
[11:47:01.157]   run `npm fund` for details
[11:47:01.190] Detected Next.js version: 14.2.5
[11:47:01.194] Detected `package-lock.json` generated by npm 7+
[11:47:01.194] Running "npm run build"
[11:47:01.332] 
[11:47:01.333] > [email protected] build
[11:47:01.333] > next build
[11:47:01.333] 
[11:47:02.450] Attention: Next.js now collects completely anonymous telemetry regarding usage.
[11:47:02.451] This information is used to shape Next.js' roadmap and prioritize features.
[11:47:02.451] You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
[11:47:02.451] https://nextjs.org/telemetry
[11:47:02.451] 
[11:47:02.515]   ▲ Next.js 14.2.5
[11:47:02.517] 
[11:47:02.593]    Creating an optimized production build ...
[11:47:42.032]  ✓ Compiled successfully
[11:47:42.033]    Linting and checking validity of types ...
[11:47:44.604]    Collecting page data ...
[11:47:45.539] Error: Default export is missing in "/vercel/path0/src/app/components/icon.jsx"
[11:47:45.540]     at 15875 (/vercel/path0/.next/server/app/components/icon/route.js:1:1642)
[11:47:45.540]     at t (/vercel/path0/.next/server/webpack-runtime.js:1:128)
[11:47:45.540]     at n (/vercel/path0/.next/server/app/components/icon/route.js:1:2731)
[11:47:45.540]     at /vercel/path0/.next/server/app/components/icon/route.js:1:2762
[11:47:45.540]     at t.X (/vercel/path0/.next/server/webpack-runtime.js:1:1206)
[11:47:45.540]     at /vercel/path0/.next/server/app/components/icon/route.js:1:2744
[11:47:45.545]     at Object.<anonymous> (/vercel/path0/.next/server/app/components/icon/route.js:1:2790)
[11:47:45.545]     at Module._compile (node:internal/modules/cjs/loader:1358:14)
[11:47:45.545]     at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
[11:47:45.545]     at Module.load (node:internal/modules/cjs/loader:1208:32)
[11:47:45.545] 
[11:47:45.545] > Build error occurred
[11:47:45.545] Error: Failed to collect page data for /components/icon
[11:47:45.545]     at /vercel/path0/node_modules/next/dist/build/utils.js:1268:15
[11:47:45.546]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
[11:47:45.546]   type: 'Error'
[11:47:45.546] }
[11:47:45.576] Error: Command "npm run build" exited with 1
[11:47:46.132]

HarshitT00 · 2024-07-22T10:36:15Z

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/feature/changer-icon*:refs/remotes/origin/feature/changer-icon* +refs/tags/feature/changer-icon*:refs/tags/feature/changer-icon*
Error: The process '/usr/bin/git' failed with exit code 1

what is this error

Bashamega · 2024-07-22T10:37:39Z

@amanr-dev Can you fix the gh actions.

Bashamega · 2024-07-22T10:38:28Z

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/feature/changer-icon*:refs/remotes/origin/feature/changer-icon* +refs/tags/feature/changer-icon*:refs/tags/feature/changer-icon* Error: The process '/usr/bin/git' failed with exit code 1

what is this error

I don't know i hope @amanr-dev can solve it

HarshitT00 · 2024-07-22T10:41:01Z

Yesterday when I made a PR this error was not there but after gh update I am getting this error

Bashamega · 2024-07-22T10:42:54Z

Yesterday when I made a PR this error was not there but after gh update I am getting this error

Because yesterday your pr was on the main branch not a sub branch like today. But we have to fix it either way. As soon as a we fix the action it will be fixed

dipanshurdev · 2024-07-22T10:53:40Z

@amanr-dev Can you fix the gh actions?

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/feature/changer-icon*:refs/remotes/origin/feature/changer-icon* +refs/tags/feature/changer-icon*:refs/tags/feature/changer-icon* Error: The process '/usr/bin/git' failed with exit code 1
What is this error

I don't know i hope @amanr-dev can solve it

This is a GitHub workflow error from the format.yml file, trying to find a solution.

HarshitT00 · 2024-07-22T11:07:01Z

Should I try to make PR by changing code in the main branch of my fork copy?

Bashamega · 2024-07-22T11:08:14Z

Should I try to make PR by changing code in the main branch of my fork copy?

As a temporary solution yes.

change the icon for toggle theme

d09d092

vercel bot had a problem deploying to Preview July 22, 2024 07:01 Failure

changer icon

89b0aab

vercel bot had a problem deploying to Preview July 22, 2024 07:35 Failure

Update icon.jsx with a default export

9db62ec

vercel bot had a problem deploying to Preview July 22, 2024 07:45 Failure

Bashamega requested changes Jul 22, 2024

View reviewed changes

Bashamega added 5 commits July 22, 2024 11:43

Update src/app/components/icon.jsx

a268cc3

Update src/app/components/icon.jsx

69ade2c

Update src/app/components/icon.jsx

9518849

Update src/app/components/icon.jsx

ae538ec

Update src/app/components/icon.jsx

b95772d

vercel bot had a problem deploying to Preview July 22, 2024 08:44 Failure

Add export default

74199f8

vercel bot had a problem deploying to Preview July 22, 2024 10:24 Failure

Create two differnt file for icon

671703e

vercel bot deployed to Preview July 22, 2024 10:33 View deployment

Bashamega closed this Jul 22, 2024

HarshitT00 deleted the feature/changer-icon branch July 22, 2024 11:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change the icon for toggle theme #190

Change the icon for toggle theme #190

HarshitT00 commented Jul 22, 2024

vercel bot commented Jul 22, 2024 •

edited

Loading

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

dipanshurdev commented Jul 22, 2024

Bashamega commented Jul 22, 2024

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

Bashamega commented Jul 22, 2024

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

dipanshurdev commented Jul 22, 2024

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

Change the icon for toggle theme #190

Change the icon for toggle theme #190

Conversation

HarshitT00 commented Jul 22, 2024

vercel bot commented Jul 22, 2024 • edited Loading

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

dipanshurdev commented Jul 22, 2024

Bashamega commented Jul 22, 2024

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

Bashamega commented Jul 22, 2024

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

dipanshurdev commented Jul 22, 2024

HarshitT00 commented Jul 22, 2024

Bashamega commented Jul 22, 2024

vercel bot commented Jul 22, 2024 •

edited

Loading