Repository navigation
Shard projection drains by owner, push wakes, fresh first, head deadline #24731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| }, | ||
| "seed_review_by": "2026-11-15", | ||
| "budget": 169, | ||
| "count": 259, | ||
| "count": 264, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: The budget metadata is stale: Prompt for AI agents |
||
| "names": { | ||
| "BATCH_PIPELINE_SERVING_PROJECTION_SWEEP": {"owner": "omi-pipeline / lead2", "review_by": "2026-12-05", "registry": "config/feature-flags.yaml"}, | ||
| "BATCH_PIPELINE_PROJECTION_PUMP_ENABLED": {"owner": "omi-pipeline / lead2", "review_by": "2026-12-05", "registry": "config/feature-flags.yaml"}, | ||
|
|
@@ -37,6 +37,11 @@ | |
| "PROJECTION_DRAIN_CLAIM_AWARE": {"owner": "two-lane lead", "review_by": "2026-12-05", "registry": "config/feature-flags.yaml"}, | ||
| "BATCH_PIPELINE_PROJECTION_STRIPING_ENABLED": {"owner": "omi-pipeline", "review_by": "2026-12-06", "registry": "config/feature-flags.yaml"}, | ||
| "K_REVISION": {"owner": "omi-pipeline", "review_by": "2026-12-06"}, | ||
| "BATCH_PROJECTION_SHARDS_ENABLED": {"owner": "two-lane lead", "review_by": "2026-12-05"}, | ||
| "BATCH_PROJECTION_SHARD_MEMBER": {"owner": "two-lane lead", "review_by": "2026-12-05"}, | ||
| "BATCH_PROJECTION_BACKLOG_RESERVE": {"owner": "two-lane lead", "review_by": "2026-12-05"}, | ||
| "BATCH_PROJECTION_HEAD_DEADLINE_SECONDS": {"owner": "two-lane lead", "review_by": "2026-12-05"}, | ||
| "BATCH_PROJECTION_BLOCKED_HEAD_DEADLINE_ENABLED": {"owner": "two-lane lead", "review_by": "2026-12-05"}, | ||
| "PARAKEET_SHAPE_CANARY_FILE": {"owner": "two-lane lead", "review_by": "2026-12-04"}, | ||
| "PARAKEET_LID_MODEL": {"owner": "planscost", "review_by": "2026-11-30"}, | ||
| "PARAKEET_LID_ONLY": {"owner": "planscost", "review_by": "2026-11-30"}, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1259,6 +1259,22 @@ below have their own switches; all three off is the pre-drain behaviour): | |
| advanced= more= elapsed_ms=` per turn, and `action=owner_chain | ||
| outcome=claim_busy`. | ||
|
|
||
| ### Owner shards and push wakes (dark, 2026-11-05) | ||
|
|
||
| `BATCH_PROJECTION_SHARDS_ENABLED` (default off) replaces the per-instance | ||
| sweep's owner discovery with owner-hash shard leases. Each owner has one | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: Prompt for AI agents |
||
| drain writer fleet-wide, and that writer is woken by merge commits rather than | ||
| by a polling keyset. | ||
|
|
||
| Only the maintenance leader pages the durable log, discovery-only, as a | ||
| backstop. Follower instances skip the sweep and keep their async follow-up | ||
| discovery. Holders fill drain slots fresh first, keeping | ||
| `BATCH_PROJECTION_BACKLOG_RESERVE` slots for backlog. | ||
|
|
||
| Any Redis failure returns that instance to the sweep. The contract, env | ||
| bounds, cutover order and rollback are in | ||
| [Batch projection owner shards](listen_pusher_pipeline.mdx#batch-projection-owner-shards). | ||
|
|
||
| ### Follow-up desync (2026-11-05) | ||
|
|
||
| Every serving process runs its own async follow-up discovery over the same | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
BATCH_PROJECTION_SHARDS_ENABLED=1orondoes not enable shards in the normal serving mode, despite the documentedtrue/1/oncontract. Parse the documented truthy values before passing the legacy value torollout_default_off.Prompt for AI agents