Repository navigation
test(billing): regenerate storefront goldens for plan catalog revision 13 - #24390
Git-on-my-level wants to merge 2 commits into
Conversation
…n 13 plan_catalog.json moved to catalog_revision 13 (#24367) while the storefront v2 goldens stayed at 12, so test_golden_storefront_scenarios fails on main and on every backend PR. Regenerated with UPDATE_STOREFRONT_GOLDENS=1; the only change is the revision number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 53 files
Confidence score: 4/5
- The
schema version 2 parses deck fieldstest still expectscatalogRevisionto be 12, but its default fixture now has 13, so the test will fail. Update the expectation to 13.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/test/fixtures/storefront_v2/cancel_scheduled_pro.json">
<violation number="1" location="app/test/fixtures/storefront_v2/cancel_scheduled_pro.json:3">
P2: The Dart test `schema version 2 parses deck fields` still expects `catalogRevision` to be 12, but its default fixture `plus_monthly_yearly_toggle.json` is now 13. Update the expectation in `app/test/models/plan_storefront_test.dart` to 13, or derive it from the fixture, and run the Flutter tests.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| { | ||
| "schema_version": 2, | ||
| "catalog_revision": 12, | ||
| "catalog_revision": 13, |
There was a problem hiding this comment.
P2: The Dart test schema version 2 parses deck fields still expects catalogRevision to be 12, but its default fixture plus_monthly_yearly_toggle.json is now 13. Update the expectation in app/test/models/plan_storefront_test.dart to 13, or derive it from the fixture, and run the Flutter tests.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At app/test/fixtures/storefront_v2/cancel_scheduled_pro.json, line 3:
<comment>The Dart test `schema version 2 parses deck fields` still expects `catalogRevision` to be 12, but its default fixture `plus_monthly_yearly_toggle.json` is now 13. Update the expectation in `app/test/models/plan_storefront_test.dart` to 13, or derive it from the fixture, and run the Flutter tests.</comment>
<file context>
@@ -1,6 +1,6 @@
{
"schema_version": 2,
- "catalog_revision": 12,
+ "catalog_revision": 13,
"show_subscription_ui": true,
"header": "Your Pro plan ends Nov 1",
</file context>
|
Superseded by #24389 (merged), per the lead. |
|
Hey @Git-on-my-level 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Before your next PR, please skim:
If this was declined for direction or taste, maintainers should cite an invariant ID or open a proposed one — ask if that citation is missing. Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! |
What
backend/config/plan_catalog.jsonmoved tocatalog_revision13 in #24367, but the storefront v2 goldens (backend and app fixtures) stayed at 12. As a result,tests/unit/test_golden_storefront_scenariosfails onmainand on every backend PR (seen on #24382, backend unit shard 4/6).The goldens were regenerated with
UPDATE_STOREFRONT_GOLDENS=1. The only change in all 52 files is"catalog_revision": 12→13.Verification
UPDATE_STOREFRONT_GOLDENS=1 BACKEND_UNIT_TEST_FILE_LIST=<test_storefront_presentation.py> bash backend/test.sh: 345 passed.Product invariants affected
none
🤖 Generated with Claude Code