Skip to content

fix(tests): refresh storefront catalog revision goldens #24389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Git-on-my-level merged 4 commits into from
Nov 2, 2026
Merged

fix(tests): refresh storefront catalog revision goldens #24389

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45613bd
fix(tests): refresh storefront catalog revision goldens
Git-on-my-level Nov 2, 2026
33064be
chore(tests): declare storefront fixture-only changelog
Git-on-my-level Nov 2, 2026
e534058
fix(tests): align storefront parser revision assertion
Git-on-my-level Nov 2, 2026
3baaed9
Merge origin/main into lane/mainred2 for final CI
Git-on-my-level Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/changelog/unreleased/20261102-storefront-catalog-revision-goldens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"kind": "none"
}
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/architect_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/cancel_scheduled_plus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Your Plus plan ends Nov 1",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/cancel_scheduled_pro.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Your Pro plan ends Nov 1",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/free_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "You've used 80% of this month's usage",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/free_mcp_cap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "You've used today's 100 MCP requests",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/free_pro_gate_proactive.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Reminders and follow-ups come with Pro",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/free_pro_gate_screen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Screen help comes with Pro",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/free_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/legacy_neo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/legacy_unlimited.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/plus_annual_current.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/plus_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,

@cubic-dev-ai cubic-dev-ai Bot Nov 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This revision bump breaks the Dart test that parses this fixture set. app/test/models/plan_storefront_test.dart still hardcodes expect(data.catalogRevision, 12); for plus_monthly_yearly_toggle.json, which now reports 13. Update that assertion to 13 in the same PR.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At app/test/fixtures/storefront_v2/plus_budget80.json, line 3:

<comment>This revision bump breaks the Dart test that parses this fixture set. `app/test/models/plan_storefront_test.dart` still hardcodes `expect(data.catalogRevision, 12);` for `plus_monthly_yearly_toggle.json`, which now reports 13. Update that assertion to 13 in the same PR.</comment>

<file context>
@@ -1,6 +1,6 @@
 {
   "schema_version": 2,
-  "catalog_revision": 12,
+  "catalog_revision": 13,
   "show_subscription_ui": true,
   "header": "You've used 80% of this month's usage",
</file context>

"show_subscription_ui": true,
"header": "You've used 80% of this month's usage",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/plus_monthly_yearly_toggle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/pro_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "You've used 80% of this month's usage",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/pro_budget_cap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "You've used all of this month's usage",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion app/test/fixtures/storefront_v2/pro_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/architect_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/cancel_scheduled_plus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Your Plus plan ends Nov 1",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/cancel_scheduled_pro.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Your Pro plan ends Nov 1",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/free_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "You've used 80% of this month's usage",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/free_mcp_cap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "You've used today's 100 MCP requests",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/free_pro_gate_proactive.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Reminders and follow-ups come with Pro",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/free_pro_gate_screen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Screen help comes with Pro",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/free_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/legacy_neo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/legacy_unlimited.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/plus_annual_current.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/plus_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "You've used 80% of this month's usage",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/plus_monthly_yearly_toggle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/pro_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "You've used 80% of this month's usage",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/pro_budget_cap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "You've used all of this month's usage",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2/pro_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Choose your plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/ar_cancel_scheduled_plus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "تنتهي خطة Plus الخاصة بك في 1 نوفمبر",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/ar_free_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "اختر خطتك",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/ar_plus_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "لقد استخدمت 80% من استخدام هذا الشهر",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/ar_pro_budget_cap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "لقد استخدمت كل استخدام هذا الشهر",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/de_cancel_scheduled_plus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Ihr Plus-Plan endet am 1. Nov.",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/de_free_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Wählen Sie Ihren Plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/de_plus_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Sie haben 80 % der Nutzung für diesen Monat verbraucht",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/de_pro_budget_cap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Sie haben die gesamte Nutzung für diesen Monat verbraucht",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/es_cancel_scheduled_plus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Tu plan Plus termina el 1 nov",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/es_free_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Elige tu plan",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/es_plus_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Has usado el 80 % del uso de este mes",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/es_pro_budget_cap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Has usado todo el uso de este mes",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/ja_cancel_scheduled_plus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "Plus プランは 11月1日 に終了します",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/ja_free_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "プランを選択",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/ja_plus_budget80.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "今月の使用量の80%を使用しました",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/ja_pro_budget_cap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "今月の使用量をすべて使用しました",
"current": {
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/fixtures/storefront_v2_l10n/zh_cancel_scheduled_plus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 2,
"catalog_revision": 12,
"catalog_revision": 13,
"show_subscription_ui": true,
"header": "你的 Plus 套餐将于 11月1日 结束",
"current": {
Expand Down
Loading
Loading