Skip to content

test(billing): preserve entitlement golden across Omi Pro display rename #24378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Git-on-my-level merged 1 commit into from
Nov 2, 2026
Merged

test(billing): preserve entitlement golden across Omi Pro display rename #24378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions backend/tests/unit/test_entitlement_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,20 @@ def captured_legacy():
return legacy_snapshot()


def test_all_main_legacy_price_entitlements_are_byte_identical(captured_legacy):
captured = captured_legacy
assert json.dumps(captured, sort_keys=True, separators=(',', ':')) + '\n' == GOLDEN.read_text()
def test_all_main_legacy_price_entitlements_are_byte_identical_except_approved_rename(captured_legacy):
expected = json.loads(GOLDEN.read_text())
# #24367 renamed unlimited_v2 to Omi Pro without changing its entitlements.
# Keep the historical fixture intact and allow only that exact display rename;
# every other definition field and runtime entitlement remains byte-pinned.
for snapshot in expected.values():
definition = snapshot['definition']
if definition['id'] == 'unlimited_v2':
assert definition['display_name'] == 'Unlimited'
definition['display_name'] = 'Omi Pro'
assert (
json.dumps(captured_legacy, sort_keys=True, separators=(',', ':')) + '\n'
== json.dumps(expected, sort_keys=True, separators=(',', ':')) + '\n'
)
assert set(expected) == set(RECOGNIZED_STRIPE_PRICE_PLAN_TYPES)
for price, snapshot in expected.items():
resolved = resolve_price_entitlements(price, {})
Expand Down
Loading