Repository navigation
backend-listen prod: explicit SERVER_BATCH_ONLY_MOBILE_PERCENT=0 - #23838
Merged
Merged
Conversation
The mobile server-batch-only cohort (ruling 73b217) was an absent default on the listen chart. Make it a reviewed explicit 0 in the prod listen values (the single declaration the feature-flag registry allows for a ramp flag; the listen roll applies the values file), so the paired 25% step is a one-line values change and rollback is the same line at 0. Regenerates the registry doc and adds a test that the value reaches the rendered container env. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ohort (Luna r1 P3) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the mobile server-batch-only cohort (ruling 73b217) an explicit, reviewed value on the prod listen chart:
SERVER_BATCH_ONLY_MOBILE_PERCENT=0.Until now the variable was absent from backend-listen, so the code default (
0, inconfig/server_batch.py) applied silently. With an explicit value:"0"→"25") that rides a normal listen roll pinned to the morning image;"0".No behavior change: the value stays 0.
Changes
backend/charts/backend-listen/prod_omi_backend_listen_values.yaml: addsSERVER_BATCH_ONLY_MOBILE_PERCENT: "0"next toBATCH_PIPELINE_PERCENT. This is the single declaration: the feature-flag registry forbids a new ramp flag in two sources, existing duplicates are allowlisted only until 2026-11-20 (workstream B), and the listen roll applies this values file (helm -f).backend/docs/feature-flag-registry.md: regenerated (scripts/render_feature_flag_registry.py --as-of 2026-10-22). Only this flag's row changes, now recording the listen declaration of 0.config/deployment-setting-classification.json: classifiesSERVER_BATCH_ONLY_MOBILE_PERCENTasconfig, a non-secret setting (likeBATCH_PIPELINE_PERCENT), for the deployment secret-boundary ratchet.backend/scripts/verify_pusher_cohost_env_diff.py: adds the flag toLISTEN_ONLY_ALLOWED["prod"]with a reason. Consumer audit (confirmed by review): the only reader isserver_batch.selected(), reached viarequest_eligible()and viaeligible()←create_in_progress_conversation, both called only fromrouters/listen; pusher's finalizer usesowned()/has_audio(). Pusher never admits capture, so it does not get the value.backend/tests/unit/test_backend_listen_helm_defaults.py:test_prod_listen_carries_an_explicit_zero_mobile_batch_only_percent. It asserts exactly one explicit"0"in the prod values, and that the value reaches the rendered container env inhelm template.No
.githubchange; the existing listen deploy workflow applies chart values.Verification
pytest tests/unit/test_backend_listen_helm_defaults.py tests/unit/test_backend_runtime_env_validator.py: 160 passed. The runtime env validator confirms the manifest/values alignment.backend/scripts/pre-deploy-check.sh(static): 341 passed, "pre-deploy checks passed".scripts/check_feature_flag_registry.py: "feature-flag registry: OK".runtime_env.yamlis unchanged from main.Product invariants affected
Failure class (fixes)
Not a fix; no declaration required.
Rollout
Ramp, deploy and merge decisions are lead-owned (two-lane rollout lead). This PR is MERGE READY only. The 25% step is a later separate values PR, applied after the batch Cloud Run services serve 25% (paired-step order).
🤖 Generated with Claude Code