Repository navigation
fix(tools): move OmiSimulator to registry crepuscularity-gpui 0.5.10 - #19068
undivisible wants to merge 2 commits into
Conversation
Upstream crepuscularity 0.9.19 replaced the git gpui-ce pins with publishable crates.io packages. Follow it: - crepuscularity-gpui 0.5.10 (was git rev afaabfc9 / 0.5.9) - gpui-ce 0.2.2 + gpui_ce_platform 0.1.0 (was git gpui-ce c738623), font-kit kept enabled on both so the window still renders text - README + .cargo/config.toml.example now document [patch.crates-io] for local path overrides No source changes: application()/gpui_window_options API is unchanged. Verified: cargo build clean, app launches, window capture shows full UI with text, BLE advertises as Omi Devkit. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dbf8-2f89-74cb-958e-f8113a19953d Co-authored-by: Amp <amp@ampcode.com>
The Home surface renders due dates with the host locale (toLocaleDateString(undefined, …)), so the hard-coded 'Due Sep 18 · Sam' only passed on en-US machines. Build the expected string with the same formatter so the gate is green on any locale. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dbf8-2f89-74cb-958e-f8113a19953d Co-authored-by: Amp <amp@ampcode.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Reviewed this end to end and it checks out cleanly. Per-file notes:
The lockfile hygiene here is exactly what we want for a registry migration — thanks for the careful pin notes in the manifest comments. Posted by automated maintainer review on David's behalf. Since this changes a build's dependency sources, the final dependency sign-off before merge stays with a human maintainer. by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with |
kodjima33
left a comment
There was a problem hiding this comment.
Dependency migration from git-rev pins to crates.io registry (crepuscularity-gpui 0.5.10 / gpui-ce 0.2.2), no API/source changes, plus a locale-independent test fix. Verified build + full check suite pass per PR description. mergeStateStatus is DIRTY (test.sh/checks-manifest-style shared-file conflict likely) — staying at approve-only per no-rebase policy.
|
Superseded: this exact change landed on the |
|
Hey @undivisible 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Before your next PR, please skim:
If this was declined for direction or taste, maintainers should cite an invariant ID or open a proposed one — ask if that citation is missing. Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! |
What
crepuscularity-gpui 0.5.10+gpui-ce 0.2.2+gpui_ce_platform 0.1.0instead of the old git rev pins (afaabfc9/c738623), following upstream crepuscularity 0.9.19.font-kitstays enabled on bothgpuiandgpui_platformso the window keeps rendering text. No source changes — API is unchanged.bun run checkis green on non-en-US machines.Verification
cargo buildclean; app launches, window capture shows full UI with text, BLE advertises as "Omi Devkit".bun run checkpasses (boundaries, format, lint, typecheck, tests, native, platform).