Skip to content

fix(tools): move OmiSimulator to registry crepuscularity-gpui 0.5.10 - #19068

Closed
undivisible wants to merge 2 commits into
v5from
fix/omi-simulator-latest-crepuscularity
Closed

undivisible wants to merge 2 commits into
v5from
fix/omi-simulator-latest-crepuscularity

Conversation

@undivisible

@undivisible undivisible commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

What

  • OmiSimulator now uses crates.io crepuscularity-gpui 0.5.10 + gpui-ce 0.2.2 + gpui_ce_platform 0.1.0 instead of the old git rev pins (afaabfc9 / c738623), following upstream crepuscularity 0.9.19. font-kit stays enabled on both gpui and gpui_platform so the window keeps rendering text. No source changes — API is unchanged.
  • Follow-up commit: the Home due-date test asserted an en-US string; it now builds the expectation with the same formatter the component uses, so bun run check is green on non-en-US machines.

Verification

  • cargo build clean; app launches, window capture shows full UI with text, BLE advertises as "Omi Devkit".
  • Full bun run check passes (boundaries, format, lint, typecheck, tests, native, platform).

Review in cubic

undivisible and others added 2 commits September 26, 2026 11:47
Upstream crepuscularity 0.9.19 replaced the git gpui-ce pins with
publishable crates.io packages. Follow it:

- crepuscularity-gpui 0.5.10 (was git rev afaabfc9 / 0.5.9)
- gpui-ce 0.2.2 + gpui_ce_platform 0.1.0 (was git gpui-ce c738623),
  font-kit kept enabled on both so the window still renders text
- README + .cargo/config.toml.example now document [patch.crates-io]
  for local path overrides

No source changes: application()/gpui_window_options API is unchanged.
Verified: cargo build clean, app launches, window capture shows full UI
with text, BLE advertises as Omi Devkit.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dbf8-2f89-74cb-958e-f8113a19953d
Co-authored-by: Amp <amp@ampcode.com>
The Home surface renders due dates with the host locale
(toLocaleDateString(undefined, …)), so the hard-coded 'Due Sep 18 · Sam'
only passed on en-US machines. Build the expected string with the same
formatter so the gate is green on any locale.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dbf8-2f89-74cb-958e-f8113a19953d
Co-authored-by: Amp <amp@ampcode.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Git-on-my-level

Copy link
Copy Markdown
Member

Reviewed this end to end and it checks out cleanly. Per-file notes:

  • tools/OmiSimulator/Cargo.toml — crepuscularity-gpui = "0.5.10" plus the gpui/gpui_platform renames to the gpui-ce 0.2.2 / gpui_ce_platform 0.1.0 registry crates. Both pins are the current unyanked releases (the newer gpui-ce 0.3.x line is yanked), and 0.2.2 is exactly the version crepuscularity-gpui 0.5.10 itself depends on, so the view! macro and the app resolve a single shared gpui instance. All three crates' crates.io repository fields point to tschk/crepuscularity and gpui-ce/gpui-ce — the same sources as the old git revs — so this swaps provenance-identical content for immutable registry artifacts.
  • tools/OmiSimulator/Cargo.lock — all 20 former git+ sources are gone; all 796 entries are now registry+https://github.com/rust-lang/crates.io-index, every one with a checksum. The semver jumps read as normal transitive refreshes (accesskit_consumer 0.35→0.37, base64 0.22→0.23, fontdb 0.23→0.24, harfrust 0.5→0.12, png 0.17→0.18.1 under an unchanged image 0.25.10). No build scripts or odd overrides introduced.
  • tools/OmiSimulator/.cargo/config.toml.example — the local path-override patch section correctly moves from [patch."https://github.com/tschk/crepuscularity"] to [patch.crates-io], matching the registry switch while keeping the gitignored override workflow intact.
  • tools/OmiSimulator/README.md — the "since crepuscularity 0.9.19" framing is accurate: upstream tag v0.9.19 exists and crepuscularity-gpui 0.5.10 was published 2026-09-16, after that release. Docs now match the manifest.
  • react-native/src/mobile/MobileAppSurface.test.tsx — the expectation now builds the due-date string with the component's exact formatter (the Due label in MobileAppSurface.tsx, toLocaleDateString with month/day/timeZone: 'UTC'), removing the en-US locale assumption. Correct fix for the flaky assertion; unrelated to the Rust change but small and harmless.

The lockfile hygiene here is exactly what we want for a registry migration — thanks for the careful pin notes in the manifest comments.

Posted by automated maintainer review on David's behalf. Since this changes a build's dependency sources, the final dependency sign-off before merge stays with a human maintainer.


by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with need human response.

@Git-on-my-level Git-on-my-level added dependency-review Touches dependencies or lockfiles; needs dependency review docs-tooling Layer: Documentation, examples, dev tools positive-signal Automation verified a genuine fix/quality contribution labels Sep 26, 2026

@kodjima33 kodjima33 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency migration from git-rev pins to crates.io registry (crepuscularity-gpui 0.5.10 / gpui-ce 0.2.2), no API/source changes, plus a locale-independent test fix. Verified build + full check suite pass per PR description. mergeStateStatus is DIRTY (test.sh/checks-manifest-style shared-file conflict likely) — staying at approve-only per no-rebase policy.

@Git-on-my-level

Copy link
Copy Markdown
Member

Superseded: this exact change landed on the v5 branch as 4030945 ("fix(tools): move OmiSimulator to registry crepuscularity-gpui 0.5.10", 2026-09-28) — registry pins, lockfile, and config example are all on v5 now, and the due-date test was fixed there with a locale-tolerant regex. The tools/OmiSimulator GPUI app doesn't exist on main. Thanks @undivisible — the registry migration you drove is what shipped.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Hey @undivisible 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

  • Project standards — Ensuring consistency across the codebase
  • User needs — Making sure changes align with what our users need
  • Code best practices — Maintaining code quality and maintainability
  • Project direction — Keeping aligned with our product principles and locked invariants

Before your next PR, please skim:

  • PRODUCT.md — product north star
  • Product invariants — locked rules (shared chat, memory tiers, agent control plane, integrations, brand)

If this was declined for direction or taste, maintainers should cite an invariant ID or open a proposed one — ask if that citation is missing.

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-review Touches dependencies or lockfiles; needs dependency review docs-tooling Layer: Documentation, examples, dev tools positive-signal Automation verified a genuine fix/quality contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants