Repository navigation
Block unverified financial outcomes in Mira replies - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reviewer-approved invented refund approval could reach the public reply. This adds a deterministic financial-outcome guard across draft parsing, review/second review, presentation and final handoff composition. The current private order lookup does not attest refund/replacement outcomes; its unrelated verification flag cannot bypass this boundary.
Removes recognized unverified refund, replacement, return, credit and warranty outcomes and financial action commitments. Keeps complete recognized policy/prerequisite/uncertainty forms, source links and the existing honest staff-delivery workflow. The multilingual outcome lexicon is bounded; safe-preservation grammar is mainly English with specific French/German uncertainty. Unrecognized mixed units fall back conservatively. No financial write, new provider stage, private fact in the public prompt, customer data or deployment.
Validation at 6c1900c: 1,280 full tests;8/8 no-model; original red-before probes, multilingual/must-keep controls, unsafe normal/compact/second review and actual-handler successful/failed handoff. Earlier independent review held several drafts; their status/condition/implicit-subject/future-commitment findings have regressions. Final independent scoped review PASS at this exact runtime. Current Node20/24 and PostgreSQL CI all PASS. Offline integration with the separate frozen device fix passes all six original #94 scenario assertions and1,289 full tests (only the helper now carries the production formatter catalog). The device candidate’s own final review/integration updates remain pending; no readiness or deployment claim for that separate PR.
Production fix A for #83 / #94, expressly allowed over the queue cap. Keep draft until independent review, combined probes and current required CI pass. Branch must be preserved. No paid comparison has run.