Skip to content

chore(catching-the-bug): adding logs to be able to understand where the Illegal Constructor Error is coming from #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanchaur wants to merge 1 commit into
base: feature/new-dom-updater
Choose a base branch
from
Open

chore(catching-the-bug): adding logs to be able to understand where the Illegal Constructor Error is coming from #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/watchers/value_observer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,21 @@ class ValueObserver {
return obj;
}

var clone = new obj.constructor();
for (var key in obj) {
if (!key.startsWith("_")) {
if (obj[key] != null && typeof obj[key] === "object") {
clone[key] = this.clone(obj[key]);
} else {
clone[key] = obj[key];
try {
var clone = new obj.constructor();
for (var key in obj) {
if (!key.startsWith("_")) {
if (obj[key] != null && typeof obj[key] === "object") {
clone[key] = this.clone(obj[key]);
} else {
clone[key] = obj[key];
}
}
}
return clone;
} catch (e) {
throw new Error(`Error while cloning object: ${JSON.stringify(obj)} - msg: ${e.message}`);
}
return clone;
}

removeSubTree(tree) {
Expand Down