Skip to content

Added additional support for variables within data-no-prevent-default and data-no-stop-propagation - backwards compatible #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdejesus007 wants to merge 3 commits into
base: feature/new-dom-updater
Choose a base branch
from
Open

Added additional support for variables within data-no-prevent-default and data-no-stop-propagation - backwards compatible #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca7c9a9
Merge pull request #27 from jdejesus007/bugfix/sio2-href
jdejesus007 Jun 13, 2020
86733ca
Added additional support for variables within data-no-prevent-default…
jdejesus007 Jun 13, 2020
7f78b8b
Merge remote-tracking branch 'bakedSoftware/silica/feature/new-dom-up…
jdejesus007 Jun 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/silica.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,17 +633,25 @@ window["Silica"] = {
if (protocolCheckRegex.exec(path) != null || path === "#" || path === "") {
return;
}

let defaultPrevented = false;
if (!this.dataset["noPreventDefault"]) {
defaultPrevented = true;
let noPreventDefault = this.dataset["noPreventDefault"] !== "true" ||
Silica.getValue(evt.currentTarget, this.dataset["noPreventDefault"]);
if (!noPreventDefault) {
evt.preventDefault();
defaultPrevented = true;
}
if (!this.dataset["noStopPropagation"]) {

let noStopProp = this.dataset["noStopPropagation"] !== "true" ||
Silica.getValue(evt.currentTarget, this.dataset["noStopPropagation"]);
if (!noStopProp) {
evt.stopPropagation();
}

// Readonly current target is only available when the event is handled thus
// pass along for client usage
PubSub.Pub("SiO2-HREF", evt, evt.currentTarget);

Silica.goTo(path);
return !defaultPrevented;
},
Expand Down