-
Notifications
You must be signed in to change notification settings - Fork 4
[WIP] New DOM Updater #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kayleg
wants to merge
64
commits into
master
Choose a base branch
from
feature/new-dom-updater
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got minified version working with new DOM updater
Contributor
Author
|
@rohenaz Looping you in here so you can see what's coming. |
attributes easier to read
Contributor
|
I had to ignore parameter and trap. Data-click-outside seems to not be working |
Contributor
Author
|
@jdejesus007 Give beta5 a try and let me know if it's working for you |
Fixes #35 Passed current target el in SiO2-HREF pub when event is handled for later sub usage
…lica into feature/new-dom-updater
Passed current target el in SiO2-HREF pub when event is handled for later sub usage
…tware/silica into feature/new-dom-updater
…nto feature/new-dom-updater
Set empty srcset if null
…rotli compression (default for dev server)
juanchaur
requested changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will bring in the new DOM updater which is must faster than the previous. Where supported Silica only updates elements which are visible in the browser's viewport.
Changes:
data-on-*can be used to register any event name instead of requiring explicit supportdata-*can be used to bind any attribute instead of explicit support ordata-silicadata-silicahas been removed in favor of the abovedata-eventNamehas been removed in favor of thedata-on-*variantSilica.ignore([...])to avoid Silica processing 3rd party dataset attributesdata-nostoppropagationis nowdata-no-stop-propagationdata-nopreventdefaultis nowdata-no-prevent-defaultmd5dependencydata-repeatJSON requirementdata-modelinsteadTodo: