Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Image upload and management for products #5

Merged
merged 16 commits into from
Sep 17, 2024
Merged

Add Image upload and management for products #5

merged 16 commits into from
Sep 17, 2024

Conversation

nanafox
Copy link
Contributor

@nanafox nanafox commented Sep 17, 2024

What this update includes

  • Introduced image upload, deletion, and listing functionalities for products.
  • Added ActiveStorage support for handling product images.
  • Updated product serializer to include image URLs.
  • Enhanced product factory to simulate image attachments.
  • Implemented custom validators for image size and content type.
  • Adjusted caching expectations in product request specs.
  • Updated schema to include ActiveStorage tables and associations.
  • Modified routes to support image-related actions for products.

@nanafox
chore: Update rubocop.yml to exclude files from linting
d388b0c
@nanafox
chore: Add faker for dummy data generation while testing
b75ae9d
@nanafox
feat: Add fixtures for testing images attached to products
0672f15
@nanafox
feat: Add ActiveStorage database migration and setup
3ed7148
@nanafox
feat: Add size and content type validators for images
392d454
@nanafox
feat: Update application.rb to autoload custom validators
770e600
@nanafox
feat: Add routes for adding and deleting images to and from products
f999036
@nanafox
feat: Add factories for products and categories
0ededee
@nanafox
test: Add tests for products and image associations
f091f60
@nanafox
feat: Add image association and validations to product.rb
92d7a1e
@nanafox
feat: Update product_serializer.rb to include image id and urls
353c9df
@nanafox
chore: Add a default error message for render_error method
3521618
@nanafox
feat: Add controller logic for adding and removing images on products
4314d7b
@nanafox
test: Refactor test and move cache key to avoid duplicates
0993a34
@nanafox
refactor: Add descriptive messages for failed validations
8e06b80
@nanafox
refactor: Use the message to give descriptive error messages
1e1e625
@nanafox nanafox added documentation Improvements or additions to documentation enhancement New feature or request ruby Pull requests that update Ruby code labels Sep 17, 2024
@nanafox nanafox self-assigned this Sep 17, 2024
@nanafox nanafox enabled auto-merge (squash) September 17, 2024 15:09
@nanafox nanafox merged commit 8be2af1 into main Sep 17, 2024
3 checks passed
@nanafox nanafox deleted the feature/api-endpoints-products-images branch September 17, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nanafox nanafox

Labels
documentation Improvements or additions to documentation enhancement New feature or request ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nanafox