Build cleanup and output declarations #343
Conversation
lynchbomb
force-pushed
the
lynchbomb
branch
6 times, most recently
from
04d0b57 to
ba49a95
Compare
|
@krisselden should be good to merge. I also wan't to confirm we still actually need |
lynchbomb
force-pushed
the
lynchbomb
branch
2 times, most recently
from
a2f5fe7 to
7214d35
Compare
| const compiled = typescript(src, { | ||
| throwOnError: process.env.EMBER_ENV === 'production', | ||
| }); | ||
|
|
||
| const compiledDeclarations = typescript('lib', { | ||
| tsconfig: { |
There was a problem hiding this comment.
In general we shouldn't need to pass tsconfig here, it should just be able to use our top level tsconfig.json.
There was a problem hiding this comment.
If we don't explicitly flag for declaration here and default to tsconfig with declaration: true we will have to cherry-pick out the .d.ts files for tests.
There was a problem hiding this comment.
Actually this brings up a good point as to; do we actually need to output tests within dist?
tsconfig.json
Outdated
| @@ -12,8 +12,8 @@ | |||
| "backburner": ["lib/index.ts"] | |||
| } | |||
| }, | |||
| "files": [ | |||
| "file": [ | |||
There was a problem hiding this comment.
I don't grok this change, I didn't think file was an option for tsconfig.json?
Hang tight on review of this PR. Im going to squash the declarations files and expose a
index.d.ts.Spiking this now. TBH there more than likely is an easier way to output generated ts declaration files. Any insight is more than welcome :)