Skip to content

Conversation

@MiiBond
Copy link
Contributor

@MiiBond MiiBond commented Oct 23, 2025

For OpenPBR, all textures that can be combined in glTF can also be assigned separately. Therefore, we need a way to easily merge textures on export.

I've written a texture-merging utility and started implmenting it for the anisotropy extensions as well as baseColor-alpha and metal-rough texture output.

I'd like feedback about this approach before I continue further. Please and thank you.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 23, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan requested a review from alexchuber October 23, 2025 22:05
Copy link
Contributor

@alexchuber alexchuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach seems on-point to me!

  • Each channel of the output texture is dictated either by a source texture + channel, or a constant value. If no configuration for a channel is defined, it falls back to a constant 1.0.
  • Using custom shader to generate a procedural texture
  • Output higher texture resolution of all source textures & sample nearest neighbor.

Thanks a TON for adding this!

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@alexchuber alexchuber merged commit d813e47 into BabylonJS:master Oct 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants