-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add AudioEngineV2 listener playwright tests #16464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AudioEngineV2 listener playwright tests #16464
Conversation
This change also adds a small .js script to the CDN to help with evaluated playwright audio tests and sound output capture.
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Reviewer - this PR has made changes to one or more package.json files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
packages/tools/tests/test/audioV2/audioEngineV2.listener.test.ts:23
- [nitpick] There is an extra space in the test description ('should be') which could be cleaned up for clarity.
test("Sound at position (0, 0, 0) with listener position option set to (1, 0, 0) should be 1x volume in left speaker and 0 volume in right speaker", async ({ page }) => {
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16464/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16464/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16464/merge#BCU1XR#0 |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
Reviewer - this PR has made changes to one or more package.json files. |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Reviewer - this PR has made changes to one or more package.json files. |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Reviewer - this PR has made changes to one or more package.json files. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16464/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16464/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16464/merge#BCU1XR#0 |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the ability to see the test results. Notice that all new tests are failing. The audio tests are currently optional and set to continue on error, this is why you see them "green" in github.
Check the last comment on this PR to open the test results.
Ok, thanks. It looks like the new tests are failing because the sound files on the assets server are not being found/loaded. AFAIK the the assets server should be visible from the CI server(s), so I'm not sure what's going wrong yet. |
Reviewer - this PR has made changes to one or more package.json files. |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
Reviewer - this PR has made changes to one or more package.json files. |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
Reviewer - this PR has made changes to one or more package.json files. |
1 similar comment
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
This change also adds a small .js script to the CDN to help with evaluated playwright audio tests and sound output capture.