Skip to content

Add AudioEngineV2 listener playwright tests #16464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

docEdub
Copy link
Contributor

@docEdub docEdub commented Apr 9, 2025

This change also adds a small .js script to the CDN to help with evaluated playwright audio tests and sound output capture.

This change also adds a small .js script to the CDN to help with evaluated playwright audio tests and sound output capture.
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Reviewer - this PR has made changes to one or more package.json files.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

packages/tools/tests/test/audioV2/audioEngineV2.listener.test.ts:23

  • [nitpick] There is an extra space in the test description ('should be') which could be cleaned up for clarity.
test("Sound at position (0, 0, 0) with listener position option set to (1, 0, 0) should  be 1x volume in left speaker and 0 volume in right speaker", async ({ page }) => {

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@docEdub docEdub marked this pull request as ready for review April 9, 2025 06:42
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the ability to see the test results. Notice that all new tests are failing. The audio tests are currently optional and set to continue on error, this is why you see them "green" in github.

Check the last comment on this PR to open the test results.

@docEdub
Copy link
Contributor Author

docEdub commented Apr 9, 2025

I added the ability to see the test results. Notice that all new tests are failing. The audio tests are currently optional and set to continue on error, this is why you see them "green" in github.

Check the last comment on this PR to open the test results.

Ok, thanks. It looks like the new tests are failing because the sound files on the assets server are not being found/loaded. AFAIK the the assets server should be visible from the CI server(s), so I'm not sure what's going wrong yet.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@docEdub docEdub merged commit a720f2c into BabylonJS:master Apr 10, 2025
17 checks passed
@docEdub docEdub deleted the 250408-add-audioenginev2-playwright-tests branch April 10, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants