Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set upper dependency bound (<= 3.4.5) on sphinx-tabs #64

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

rocco8773
Copy link
Member

@rocco8773 rocco8773 commented Oct 8, 2024

Changes made in executablebooks/sphinx-tabs#198 are causing the tabs.css to not be included when a page is build. I'm currently not sure what the exact culprit is. v3.4.5 still properly includes the CSS.

For version >3.4.5 the tabs should up as regular html buttons...
image

Instead of...
image

@rocco8773 rocco8773 added the documentation Improvements or additions to documentation label Oct 8, 2024
@rocco8773
Copy link
Member Author

I'm closing this PR since the RTD build that was displaying this issue miraculously started displaying correctly. I'm guessing this might be a browser caching issue.

@rocco8773 rocco8773 closed this Oct 8, 2024
@rocco8773
Copy link
Member Author

And the issue came back... 🤦‍♂️

@rocco8773 rocco8773 reopened this Oct 8, 2024
@rocco8773 rocco8773 merged commit 19d74c7 into main Oct 8, 2024
1 check passed
@stsewd
Copy link

stsewd commented Nov 11, 2024

Hi, I arrived here from executablebooks/sphinx-tabs#198. At RTD we also saw this problem, it was due to sphinx-hoverxref depending on the old behavior from sphinx-tabs, it should be fixed with readthedocs/sphinx-hoverxref#318. Just letting you know so you can update once the fix is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants