Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download module when deleting corrupted pair-end data #419

Merged
merged 34 commits into from
Feb 27, 2025
Merged

Fix download module when deleting corrupted pair-end data #419

merged 34 commits into from
Feb 27, 2025

Conversation

Aberdur
Copy link
Contributor

@Aberdur Aberdur commented Feb 25, 2025

PR Description

In download module, when a sample has pair-end data and one of the pairs is corrupted and the other one is uncompressed, it can't delete it. To solve this problem, the logic has been modified:

  1. Removes both files from a pair-end if at least one is corrupt.
  2. Ensures that no corrupt files are added to the list of files to be compressed.
  3. Only after deleting corrupted files are uncompressed files compressed.

@Aberdur Aberdur linked an issue Feb 25, 2025 that may be closed by this pull request
Error deleting pair-end data #405
Closed
Shettland
Shettland approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@Shettland Shettland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aberdur Aberdur marked this pull request as draft February 25, 2025 14:09
@Aberdur Aberdur marked this pull request as ready for review February 27, 2025 09:00
@Shettland Shettland merged commit 905e3ad into BU-ISCIII:develop Feb 27, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shettland Shettland Shettland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error deleting pair-end data
2 participants
@Aberdur @Shettland