Introduced log_summary module for custom logs. Improvements in read-lab and excel-merging in sftp_handle #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amples_data.json. Also some troubleshooting
|
LGTM but it doesn't complete closes #245 as no email is sent to researcher, you can close it but create a new issue just for the email sending :) |
saramonzon
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new module that can be used in every process to create a custom Log report in Json format, This PR also includes its functionalities in sftp-handle and read-lab-metadata, which also received several improvements in error handling.
The changes in read-lab-metadata include the rejection of conflicting fields, so they are not included in the output processed Json file. Therefore, this enables the recognition of not provided fields by the validation module and Closes #250
Moreover, now sftp-handle's download module pre-merges multiple metadata files in remote repository if they are found in the same folder prior to merging those from different folders.
This also closes #245