Skip to content

feat: Add Custom Notes feature for uninstaller entries#939

Merged
Klocman merged 1 commit into
BCUninstaller:masterfrom
ronimuliawan:fix-#932
Jun 18, 2026
Merged

feat: Add Custom Notes feature for uninstaller entries#939
Klocman merged 1 commit into
BCUninstaller:masterfrom
ronimuliawan:fix-#932

Conversation

@ronimuliawan

Copy link
Copy Markdown
Contributor
  • Added CustomNotesManager to save and load notes persistently via XML (CustomNotes.xml).
  • Injected CustomNote property into ApplicationUninstallerEntry to bind notes directly to entries.
  • Created CustomNoteDialog UI to allow users to view and edit notes.
  • Added a "Custom Note" column to the main uninstaller list view.
  • Added an "Edit Custom Note..." option to the right-click context menu in the main window.
  • Fixed legacy MSTest compilation errors in DrawingToolsTests and UninstallListTests for .NET 8 compatibility.

Resolves #932

@ronimuliawan

Copy link
Copy Markdown
Contributor Author

Some images on how it works

Screenshot 2026-06-14 203428 Image 1: this is the UI for adding new custom notes Screenshot 2026-06-14 203549 Image 2: this is the UI for adding new custom notes, after typing and clicking ok, it will get saved Screenshot 2026-06-14 203610 Image 3: double clicking on items Screenshot 2026-06-14 203634 Image 4: this is the UI for editing existing custom notes, all text selected by default

Pardon for the washed color on the screenshot, HDR. Hmm.
Anyway, this is my first time ever to contribute to an open source project, if I made a mistake along the way, let me know so I can learn something new.

I made some changes that probably I could have avoid:

  1. source/BulkCrapUninstallerTests/DrawingToolsTests.cs
  2. source/BulkCrapUninstallerTests/UninstallListTests.cs

especially on number 2, this is probably due to my visual studio build tools version, I am using 2026 and I can't install 2022 due to limited disk space and internet quota (I'm on the road right now), the build process kept throwing error around those codes.

-Ron

@ronimuliawan ronimuliawan marked this pull request as ready for review June 14, 2026 14:10

@Klocman Klocman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally looks fine but there's some issues and oddities that prevent a merge.


I think the way the notes are implemented currently they have a very limited use since you cannot see the note or even know that the note exists by looking at the application list.
You have to know that there is a note for that specific item and manually open the note editor to read it, but if you remember there is a note you probably also remember what the note is saying.

I don't know how to resolve this, but as it is now it's unlikely to be used much. Maybe it could be shown on the left sidebar when selected, or in a tooltip on mouse hover. It could also show an extra note icon for the uninstaller entry, and hovering over that would show the tooltip? I'm open to discussion and different takes on this.

Comment thread source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs Outdated
Comment thread source/UninstallTools/UninstallTools.csproj Outdated
Comment thread source/UninstallTools/CustomNotesManager.cs
Comment thread source/UninstallTools/ApplicationUninstallerEntry.cs
Comment thread source/BulkCrapUninstallerTests/UninstallListTests.cs Outdated
Comment thread source/BulkCrapUninstaller/Forms/Helpers/CustomNoteDialog.cs Outdated
@Klocman

Klocman commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Pull from upstream to fix the failing check.

@ronimuliawan

Copy link
Copy Markdown
Contributor Author

Functionally looks fine but there's some issues and oddities that prevent a merge.

I think the way the notes are implemented currently they have a very limited use since you cannot see the note or even know that the note exists by looking at the application list. You have to know that there is a note for that specific item and manually open the note editor to read it, but if you remember there is a note you probably also remember what the note is saying.

I don't know how to resolve this, but as it is now it's unlikely to be used much. Maybe it could be shown on the left sidebar when selected, or in a tooltip on mouse hover. It could also show an extra note icon for the uninstaller entry, and hovering over that would show the tooltip? I'm open to discussion and different takes on this.

on the app list you can see it at the very right side of things, which can be dragged if needed. I intentionally create a very bare minimum working feature without thinking of adding any special icons and other UI elements, so you can give me some inputs about how you do things around here, a little bit discussion and maybe a couple of commits later we are good to go. Tbh, I don't really know what I should add because this is my very first time contributing to any open-source project, so I decided to just took the description of the issue very literal

some images:
Screenshot 2026-06-15 195708
Screenshot 2026-06-15 195845
Screenshot 2026-06-15 195943
Screenshot 2026-06-15 195949

@ronimuliawan

Copy link
Copy Markdown
Contributor Author

thanks for all the feedback, I have read them all carefully, I will make some adjustment and get back to you

dang this is exiciting

@ronimuliawan ronimuliawan force-pushed the fix-#932 branch 3 times, most recently from e5e8478 to 516a0cd Compare June 15, 2026 16:57

@ronimuliawan ronimuliawan left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all issue has been addressed, I also added a comment on each comment you made. I tried running the action on my fork, it passed

@ronimuliawan ronimuliawan requested a review from Klocman June 15, 2026 17:18

@Klocman Klocman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes. I think the current column approach is good enough to merge.

The edit custom note item should be moved above Properties I think, It can be named simply "Edit note...".

Once this review is addressed it should be good to merge.

Comment thread source/BulkCrapUninstaller/Forms/Helpers/CustomNoteDialog.cs Outdated
Comment thread source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs Outdated
Comment thread source/UninstallTools/ApplicationUninstallerEntry.cs Outdated
Comment thread installer/BcuSetup.iss
@ronimuliawan

Copy link
Copy Markdown
Contributor Author

Suggestions to add for custom note, just pushing it a little bit further:

  1. Sequential Popups: bulk change but every single apps can have different notes, example: app A, B, C, D, E are selected, but app A has note "This is used for windows development". app B has note "This is used for rust development", app C has note "This is used for android development", app D and E has the same note "This is a must have for any development work". Note for app E can be the same as app D by checking a box called "Same Note as the previous app (App Name Here)" which NOT selected by default, the default text for the note should be empty if it's a new note, or what's in there previously if the user already has note.
  2. Multi-Edit Grid: like no 2 but instead of treating it like a questioner or survey, just show all 5 of the and then the user can edit all of it simultaneously.

a must have for these 2 features is a HARD cap on how many apps can be selected at any given time. The maximum amount a user can select and edit, should not be more than 6.

Because:

  • protecting from crash due to miss click, 100+ popups is a nightmare to cancel and might lead to a crash (just my opinion).
  • limited UI space for multi-edit grid. Having 10+ editing grid is weird..

what do you think? if it aligns, I can create a new PR just for this 2 features.

- Added `CustomNotesManager` to save and load notes persistently via XML (`CustomNotes.xml`).
- Injected `CustomNote` property into `ApplicationUninstallerEntry` to bind notes directly to entries.
- Created `CustomNoteDialog` UI to allow users to view and edit notes.
- Added a "Custom Note" column to the main uninstaller list view.
- Added an "Edit Custom Note..." option to the right-click context menu in the main window.
- Fixed legacy MSTest compilation errors in `DrawingToolsTests` and `UninstallListTests` for .NET 8 compatibility.

Resolves BCUninstaller#932
@ronimuliawan ronimuliawan force-pushed the fix-#932 branch 3 times, most recently from cde19a6 to 9a2ac53 Compare June 18, 2026 12:20
@ronimuliawan ronimuliawan requested a review from Klocman June 18, 2026 12:30
@ronimuliawan

Copy link
Copy Markdown
Contributor Author

all issue has been addressed, I also added a comment on each comment you made. I tried running the action on my fork, it passed

let me know if you think any other changes should be made!

@Klocman Klocman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you for the PR!

@Klocman Klocman merged commit f396633 into BCUninstaller:master Jun 18, 2026
2 checks passed
@ronimuliawan

Copy link
Copy Markdown
Contributor Author

my pleasure! onto the next one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom note on an item

2 participants