BugFix #896 Clean generated files on uninstall#928
Merged
Klocman merged 4 commits intoJun 9, 2026
Conversation
One-Simon
changed the title
Collaborator
Author
|
Whoops - you just did that yourself :D How about you mark some Issues that you would like to see resolved first ? |
Collaborator
Author
|
@Klocman Could you maybe check my PR anyways, after testing yours i still had at least "{app}\UsageStatistics.xml" not uninstalled in my local installation |
Klocman
approved these changes
Jun 9, 2026
Collaborator
|
That's a lot better than my limited list, thanks for the PR. I'm trying to get a release out today so I've skipped a few steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #896.
Adds Inno Setup
[UninstallDelete]entries for files generated by BCU itself, including settings, logs, info/certificate caches, usage statistics, rating caches, and crash report zips. Installed files are still handled by the normal Inno uninstall log.I ran testing against the old & new uninstall and it seems to catch all.
Testing: