Feature/728 slippage protection vaults - #826
Open
rabsqueen wants to merge 2 commits into
Open
Conversation
…in_shares_out and min_tokens_out (BCPathway#728)
|
@rabsqueen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@rabsqueen please fix CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements user-configurable slippage protection for the Yield-Bearing Fee Vault, allowing users to specify the minimum amount they are willing to receive from deposits and withdrawals.
Depositors can provide min_shares_out, while withdrawers can provide min_tokens_out. If the calculated output falls below the specified minimum, the transaction reverts instead of executing at an unfavorable rate.
What Changed
📥 Deposit Slippage Protection
min_shares_out
Result
The Yield-Bearing Fee Vault now provides user-controlled slippage protection for deposits and withdrawals.
Users can define the minimum acceptable output for each operation, preventing unexpected vault-state changes or conversion-rate movements from resulting in an execution that falls below their specified tolerance.
Closes #728