Skip to content

Commit

Permalink
Updating Ruby 2.6 (2.6.8) Dockerfile with Node 8 to Yarn 1.22.4
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinbbd committed Mar 31, 2022
1 parent 6a3ad5d commit 937e9a0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion 2.6/buster/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:2.6.7
FROM ruby:2.6.8
RUN apt-get update -qq && apt-get install -y build-essential

# for postgres
Expand Down
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ There will be multiple variants of the tag versions to assist with selecting a s

The Ruby, Node, and Yarn dependencies will be separated by a `-` and will be used in the following order: `RUBY-NODE-YARN`

An example of using Ruby `2.6.7`, with Node `8.17.0` and Yarn `1.22.4` would be: `2.6.7-8.17.0-1.22.4`
An example of using Ruby `2.6.8`, with Node `8.17.0` and Yarn `1.22.4` would be: `2.6.8-8.17.0-1.22.4`

## Supported tags and respective `Dockerfile` links

- [`latest`, `2.6.7-8.17.0-1.22.4` (2.6/Dockerfile)](https://github.com/BBD-Development/docker-ruby-node-yarn/blob/master/2.6/buster/Dockerfile)
- [`latest`, `2.6.8-8.17.0-1.22.4` (2.6/Dockerfile)](https://github.com/BBD-Development/docker-ruby-node-yarn/blob/master/2.6/buster/Dockerfile)
- [`2.5.8-8.17.0-1.22.4` (2.5-8/Dockerfile)](https://github.com/BBD-Development/docker-ruby-node-yarn/blob/master/2.5-8/buster/Dockerfile)

## Image Variants
Expand Down Expand Up @@ -53,11 +53,11 @@ This image uses `C.UTF-8` instead of the default `POSIX`.
- Commit locally as one commit and indicate which versions have changed in the commit message
- Build the Docker changes locally and tag it the same way as you want it on docker but exclude the organization.
```
docker build -f 2.6/buster/Dockerfile -t ruby-node-yarn:2.6.7-8.17.0-1.22.4 .
docker build -f 2.6/buster/Dockerfile -t ruby-node-yarn:2.6.8-8.17.0-1.22.4 .
```
- Tag the commit with the same Docker tag that is being added (don't push yet)
```
git tag 2.6.7-8.17.0-1.22.4
git tag 2.6.8-8.17.0-1.22.4
```
- If the build succeeds, then push your local Git repo with the pending commit/tag to the remote master branch
```
Expand All @@ -67,13 +67,13 @@ This image uses `C.UTF-8` instead of the default `POSIX`.
```
docker images
REPOSITORY TAG IMAGE ID
ruby-node-yarn 2.6.7-8.17.0-1.22.4 3451cc44c630
ruby-node-yarn 2.6.8-8.17.0-1.22.4 8bbcec4190ff
docker tag 3451cc44c630 bbdinc/ruby-node-yarn:2.6.7-8.17.0-1.22.4
docker tag 3451cc44c630 bbdinc/ruby-node-yarn:latest
docker tag 8bbcec4190ff bbdinc/ruby-node-yarn:2.6.8-8.17.0-1.22.4
docker tag 8bbcec4190ff bbdinc/ruby-node-yarn:latest
```
- Final step, is to push the Docker tags to Dockerhub. Reminder, ensure you are logged into Dockerhub hub locally before attempting to push using [docker login](https://docs.docker.com/engine/reference/commandline/login/)
```
docker push bbdinc/ruby-node-yarn:2.6.7-8.17.0-1.22.4
docker push bbdinc/ruby-node-yarn:2.6.8-8.17.0-1.22.4
docker push bbdinc/ruby-node-yarn:latest
```

0 comments on commit 937e9a0

Please sign in to comment.