Add Universe PWA branding#26
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the play application to support PWA installation and branding. A new Web App Manifest is created with Universe identity (name, icons, orientation), and the HTML head is updated to reference this manifest and add Apple mobile web app support meta tags. ChangesPWA Branding Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@play/public/manifest.webmanifest`:
- Line 4: Update the "description" value in manifest.webmanifest to use the
exact required string by replacing the ASCII hyphen (-) between "BAWES Universe"
and "a virtual world" with an em dash (—) so the value reads "BAWES Universe — a
virtual world"; ensure you modify the "description" property shown in the diff.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bc984c12-6e8d-4c00-b4ef-e51abdf516c8
⛔ Files ignored due to path filters (2)
play/public/static/universe-icon-192.pngis excluded by!**/*.pngplay/public/static/universe-icon-512.pngis excluded by!**/*.png
📒 Files selected for processing (2)
play/index.htmlplay/public/manifest.webmanifest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a275425d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <link rel="{{ rel }}" type="image/png" sizes="{{ sizes }}" href="{{ src }}" /> | ||
| {{/favIcons}} | ||
| <link rel="manifest" href="/static/images/favicons/manifest.json?url={{ url }}" /> | ||
| <link rel="manifest" href="/manifest.webmanifest" /> |
There was a problem hiding this comment.
Preserve room URL in installed PWA launch target
Linking index.html to the static /manifest.webmanifest makes every install use the hardcoded start_url: "/" from that file, whereas the previous manifest URL included ?url={{ url }} and displayManifestJson derived the launch URL from the current room path. In deployments where users install from a room URL like /@/..., launching the installed app will now always send them to / instead of back to that room, which is a functional regression for deep-linked worlds.
Useful? React with 👍 / 👎.
|
Addressed the manifest description nit in 9e2784e by using the requested em dash wording.\n\nVerification:\n- node manifest validation for description/name/icon entries\n- npx prettier --check play/public/manifest.webmanifest\n- git diff --check |
Summary
play/public/staticCloses #3
/claim #1
Demo
Verification
npx prettier --check play/public/manifest.webmanifestgit diff --checknpm run build --workspace playwas attempted, but the production build hit the local Node heap/process limit after transforming 3373 modules; no failure was tied to this PWA metadata/icon change