fix(mobile): hide screen sharing in native webviews#23
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Related to #13
Related to #1
/claim #1
Summary
getDisplayMediapathmobile/README.mdwhile leaving camera/mic and iframe behavior unchangedWhy this slice
This is a narrow follow-up from #13, not the full WebView compatibility issue. The goal is to handle the known mobile screen-share limitation cleanly without overlapping the already-open Android/iOS platform PRs (#21 and #22), the push work in #11, or the update flow in #12.
Verification
git diff --checknpm exec --workspace play -- prettier --check src/front/WebRtc/DeviceUtils.ts src/front/WebRtc/DeviceUtils.test.ts src/front/Stores/ScreenSharingStore.tsEnvironment limitations
npm test --workspace play -- DeviceUtils.test.tsis currently blocked by the repo's Vite/Svelte setup onuniverse(vite.config.mtsimportssveltePreprocessas a named export from the CommonJSsvelte-preprocesspackage)npm run typecheck --workspace playis also already failing on the currentuniversebranch because generated@workadventure/messagesprotobuf outputs and related imports are missing from the workspace checkoutnpm exec --workspace play -- eslint ...still reports the pre-existingimport/no-unresolvedproblem for../../i18n/i18n-svelteinsideScreenSharingStore.ts; this resolver issue exists on the branch independently of this sliceDemo
This slice has no visual asset change or native build artifact. The user-facing behavior change is that the screen-share control is no longer advertised inside the Capacitor mobile shell, and the README now documents that screen sharing remains browser-only on mobile.