Skip to content

feat: replace ng5-slider with @angular-slider/ngx-slider #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gacorpoll-ui wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: replace ng5-slider with @angular-slider/ngx-slider #58

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
509955c
feat: replace ng5-slider with @angular-slider/ngx-slider
May 15, 2026
007f3c1
chore: replace ng5-slider with @angular-slider/ngx-slider
May 15, 2026
74ddf80
chore: replace moment.js with date-fns v3
May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 32 additions & 52 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
},
"private": true,
"dependencies": {
"@angular-slider/ngx-slider": "^14.0.0",

@coderabbitai coderabbitai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🌐 Web query:

@angular-slider/ngx-slider compatibility with Angular 15

💡 Result:

The @angular-slider/ngx-slider package provides explicit support for Angular 15 [1][2][3]. Specifically, version 15.x of the library is designed to be compatible with Angular 15 and requires RxJS 7.x [1][2][3]. You can verify this compatibility in the official package documentation and the project's changelog, which confirms that the 15.0.0 release was a backport targeting Angular 15 [1][4]. Note that as of May 2026, the maintainers only actively support the latest three versions of the library [1][2].

Citations:

Update @angular-slider/ngx-slider to version 15.x for Angular 15 compatibility.

The current version ^14.0.0 is not compatible with Angular 15. The library provides version 15.x specifically designed for Angular 15 with RxJS 7.x support. Update the dependency to ^15.0.0.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 21, Update the package.json dependency for the Angular
slider: replace the current version specifier for "@angular-slider/ngx-slider"
(currently "^14.0.0") with the Angular-15 compatible release "^15.0.0" so the
project uses the library built for Angular 15 / RxJS 7 compatibility; then run
your dependency install (npm/yarn) and verify no breaking peer dependency
warnings.

"@angular/common": "^15.0.0",
"@angular/core": "^15.0.0",
"@angular/forms": "^15.0.0",
Expand Down Expand Up @@ -60,7 +61,6 @@
"ionicons": "^6.0.3",
"mixpanel-browser": "^2.45.0",
"moment": "^2.30.1",
"ng5-slider": "^1.2.6",
"rxjs": "~7.5.0",
"tslib": "^2.3.0",
"zone.js": "~0.11.4"
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/age-refinement-list/age-refinement-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
{{ value.upper | age }}
</ion-label>

<ng5-slider [(value)]="value.lower" [(highValue)]="value.upper"
<ngx-slider [(value)]="value.lower" [(highValue)]="value.upper"
(userChangeEnd)="handleChange()"
(userChange)="setLabel()" [options]="options"></ng5-slider>
(userChange)="setLabel()" [options]="options"></ngx-slider>
<!--
<ion-range debounce="500" dualKnobs="true" (ionChange)="handleChange($event)"
[value]="value"
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/age-refinement-list/age-refinement-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { connectRange } from 'instantsearch.js/es/connectors';
import { RangeRenderState } from 'instantsearch.js/es/connectors/range/connectRange';
import { BaseWidget, NgAisIndex, NgAisInstantSearch } from 'angular-instantsearch';
import { parseNumberInput, noop } from 'angular-instantsearch/esm2015/utils';
import { Options } from 'ng5-slider';
import { Options } from '@angular-slider/ngx-slider';


@Component({
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/age-refinement-list/age-refinement-list.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { Ng5SliderModule } from 'ng5-slider';
import { NgxSliderModule } from '@angular-slider/ngx-slider';
import { FormsModule } from '@angular/forms';
import { NgAisModule } from 'angular-instantsearch';
import { IonicModule } from '@ionic/angular';
Expand All @@ -18,7 +18,7 @@ import { AgeRefinementListComponent } from './age-refinement-list.component';
CommonModule,
FormsModule,
PipesModule,
Ng5SliderModule,
NgxSliderModule,
],
exports: [
AgeRefinementListComponent
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/date-range-refinement-list/date-range-refinement-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { BaseWidget, NgAisIndex, NgAisInstantSearch } from 'angular-instantsearc
import { parseNumberInput, noop } from 'angular-instantsearch/esm2015/utils';
import {CalendarModal, CalendarModalOptions, CalendarResult} from 'ion2-calendar';
import { ModalController } from '@ionic/angular';
import {Options} from "ng5-slider";
import {Options} from "@angular-slider/ngx-slider";

@Component({
selector: 'date-range-refinement-list',
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/range-refinement-list/range-refinement-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
{{ value.upper | age }}
</ion-label>

<ng5-slider [(value)]="value.lower" [(highValue)]="value.upper"
<ngx-slider [(value)]="value.lower" [(highValue)]="value.upper"
(userChangeEnd)="handleChange()"
(userChange)="setLabel()" [options]="options"></ng5-slider>
(userChange)="setLabel()" [options]="options"></ngx-slider>
<!--
<ion-range debounce="500" dualKnobs="true" (ionChange)="handleChange($event)"
[value]="value"
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/range-refinement-list/range-refinement-list.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { FormsModule } from "@angular/forms";
import { RangeRefinementComponent } from './range-refinement-list';

import { NgAisModule } from 'angular-instantsearch';
import { Ng5SliderModule } from 'ng5-slider';
import { NgxSliderModule } from '@angular-slider/ngx-slider';

import { PipesModule } from '../../pipes/pipes.module';

Expand All @@ -21,7 +21,7 @@ import { PipesModule } from '../../pipes/pipes.module';
CommonModule,
FormsModule,
PipesModule,
Ng5SliderModule,
NgxSliderModule,
],
exports: [
RangeRefinementComponent
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/range-refinement-list/range-refinement-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { connectRange } from 'instantsearch.js/es/connectors';
import { RangeRenderState } from 'instantsearch.js/es/connectors/range/connectRange';
import { BaseWidget, NgAisIndex, NgAisInstantSearch } from 'angular-instantsearch';
import { parseNumberInput, noop } from 'angular-instantsearch/esm2015/utils';
import { Options } from 'ng5-slider';
import { Options } from '@angular-slider/ngx-slider';


@Component({
Expand Down
10 changes: 5 additions & 5 deletions src/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,13 +432,13 @@ ion-calendar-modal {
margin: 0 auto !important;
}

ng5-slider {
ngx-slider {
$handleSize: 12px;

background: var(--ion-color-custom-2) !important;
margin: 10px 0 15px !important;

.ng5-slider-pointer {
.ngx-slider-pointer {
width: 12px !important;
height: 12px !important;
top: -4px !important;
Expand All @@ -451,11 +451,11 @@ ng5-slider {
}
}

.ng5-slider-selection {
.ngx-slider-selection {
background: var(--ion-color-custom-3) !important;
}

.ng5-slider-bubble {
.ngx-slider-bubble {
display: none !important;
}
}
Expand Down Expand Up @@ -850,4 +850,4 @@ ion-content {

.popover-job-search-status {
--width: 309px;
}
}