-
Notifications
You must be signed in to change notification settings - Fork 24
feat: replace ng5-slider with @angular-slider/ngx-slider #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ | |
| }, | ||
| "private": true, | ||
| "dependencies": { | ||
| "@angular-slider/ngx-slider": "^14.0.0", | ||
| "@angular/common": "^15.0.0", | ||
| "@angular/core": "^15.0.0", | ||
| "@angular/forms": "^15.0.0", | ||
|
|
@@ -48,19 +49,18 @@ | |
| "@sentry/browser": "^7.92.0", | ||
| "@sentry/cli": "^2.24.1", | ||
| "@tinymce/tinymce-angular": "^7.0.0", | ||
| "algoliasearch": "^4.23.3", | ||
| "angular-instantsearch": "^4.4.0", | ||
| "algoliasearch": "^5.52.1", | ||
| "aws-sdk": "^2.1279.0", | ||
| "chart.js": "^4.1.1", | ||
| "cordova-plugin-file": "^7.0.0", | ||
| "cordova-plugin-nativestorage": "^2.3.2", | ||
| "date-fns": "^2.29.3", | ||
| "file-saver": "^2.0.5", | ||
| "instantsearch.js": "^4.97.0", | ||
|
Comment on lines
+52
to
+59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Check for v4-only Algolia API usage (expected: no matches):"
rg -nP --type=ts -C2 "\\binitIndex\\s*\\("
echo
echo "Locate Algolia imports and nearby usage:"
rg -nP --type=ts -C2 "from\\s+['\\\"]algoliasearch(?:/lite)?['\\\"]"
echo
echo "Inspect Algolia service wrappers for migrated method patterns:"
fd -i "algolia*.ts" src | xargs -r rg -n -C2 "algoliasearch|initIndex|search\\(|saveObject|saveObjects|deleteIndex|operationIndex"Repository: BAWES-Universe/studenthub-staff Length of output: 2941 Migrate Algolia v4 API calls to v5 before applying package upgrade. The
Replace 🤖 Prompt for AI Agents |
||
| "ion2-calendar": "^3.5.0", | ||
| "ionicons": "^6.0.3", | ||
| "mixpanel-browser": "^2.45.0", | ||
| "moment": "^2.30.1", | ||
| "ng5-slider": "^1.2.6", | ||
| "rxjs": "~7.5.0", | ||
| "tslib": "^2.3.0", | ||
| "zone.js": "~0.11.4" | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,9 +4,9 @@ import { NavController, Platform, MenuController, PopoverController, IonContent, | |||||||||||||||
| import { environment } from '../../../../../environments/environment'; | ||||||||||||||||
| import { HttpClient, HttpHeaders } from '@angular/common/http'; | ||||||||||||||||
| import { TransferState, makeStateKey } from '@angular/platform-browser'; | ||||||||||||||||
| import algoliasearch from 'algoliasearch/index'; | ||||||||||||||||
| // import algoliasearch from 'algoliasearch/index'; | ||||||||||||||||
| import * as VERSION from 'algoliasearch-helper/src/version'; | ||||||||||||||||
| import * as encodeProxy from 'querystring-es3/encode'; | ||||||||||||||||
| import * as encodeProxy from 'querystring-es3'; | ||||||||||||||||
|
Comment on lines
+7
to
+9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify unresolved symbol risk in this file
rg -n "algoliasearch\\(" src/app/pages/logged-in/candidate/candidate-search/candidate-search.page.ts
rg -n "import\\s+algoliasearch" src/app/pages/logged-in/candidate/candidate-search/candidate-search.page.tsRepository: BAWES-Universe/studenthub-staff Length of output: 183 🏁 Script executed: cat -n src/app/pages/logged-in/candidate/candidate-search/candidate-search.page.ts | head -50Repository: BAWES-Universe/studenthub-staff Length of output: 2326 🏁 Script executed: cat -n src/app/pages/logged-in/candidate/candidate-search/candidate-search.page.ts | sed -n '320,340p'Repository: BAWES-Universe/studenthub-staff Length of output: 947 🏁 Script executed: rg -n "algoliasearch" src/app/pages/logged-in/candidate/candidate-search/candidate-search.page.tsRepository: BAWES-Universe/studenthub-staff Length of output: 246
Line 7 comments out the import, but Uncomment and update the import path: Fix-// import algoliasearch from 'algoliasearch/index';
+import algoliasearch from 'algoliasearch/lite';📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| // service | ||||||||||||||||
| import { AuthService } from '../../../../providers/auth.service'; | ||||||||||||||||
| import { CandidateService } from '../../../../providers/logged-in/candidate.service'; | ||||||||||||||||
|
|
||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,7 +3,7 @@ import { NavController, Platform, MenuController, PopoverController, IonContent, | |||||
| import { environment } from '../../../../../environments/environment'; | ||||||
| import { HttpClient, HttpHeaders } from '@angular/common/http'; | ||||||
| import { TransferState, makeStateKey } from '@angular/platform-browser'; | ||||||
| import algoliasearch from 'algoliasearch'; | ||||||
| // import algoliasearch from 'algoliasearch'; | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify unresolved symbol risk in this file
rg -n "algoliasearch\\(" src/app/pages/logged-in/fulltimer/fulltimer-search/fulltimer-search.page.ts
rg -n "import\\s+algoliasearch" src/app/pages/logged-in/fulltimer/fulltimer-search/fulltimer-search.page.tsRepository: BAWES-Universe/studenthub-staff Length of output: 177 Uncomment The Fix-// import algoliasearch from 'algoliasearch';
+import algoliasearch from 'algoliasearch/lite';📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| import * as VERSION from 'algoliasearch-helper/src/version'; | ||||||
| import * as encodeProxy from 'querystring-es3/encode'; | ||||||
| // service | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { Injectable } from '@angular/core'; | ||
| import algoliasearch from 'algoliasearch/lite'; | ||
| import instantsearch from 'instantsearch.js'; | ||
| import { environment } from '../../environments/environment'; | ||
|
|
||
| @Injectable({ providedIn: 'root' }) | ||
| export class AlgoliaService { | ||
| readonly client = algoliasearch(environment.algoliaAppId, environment.algoliaSearchKey); | ||
|
|
||
| createIndex(indexName: string) { | ||
| return this.client.initIndex(indexName); | ||
|
Comment on lines
+10
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: Yes, the Citations:
🏁 Script executed: # Check package.json for algoliasearch version
cat package.json | grep -A 2 -B 2 "algoliasearch"Repository: BAWES-Universe/studenthub-staff Length of output: 233 🏁 Script executed: # Read the full algolia.service.ts file
cat -n src/app/providers/algolia.service.tsRepository: BAWES-Universe/studenthub-staff Length of output: 610 🏁 Script executed: # Search for usages of createIndex method
rg "createIndex" --type ts --type js -B 2 -A 2Repository: BAWES-Universe/studenthub-staff Length of output: 436 🏁 Script executed: # Search for actual usages/calls to createIndex method
rg "\.createIndex\(" --type ts --type js -B 2 -A 2Repository: BAWES-Universe/studenthub-staff Length of output: 57 🏁 Script executed: # Also search for AlgoliaService usage patterns
rg "AlgoliaService" --type ts --type js -B 2 -A 2Repository: BAWES-Universe/studenthub-staff Length of output: 4212
The package uses algoliasearch v5.52.1, which removed 🤖 Prompt for AI Agents |
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
@angular-slider/ngx-slider compatibility with Angular 15💡 Result:
The
@angular-slider/ngx-sliderpackage provides explicit support for Angular 15 [1][2][3]. Specifically, version 15.x of the library is designed to be compatible with Angular 15 and requires RxJS 7.x [1][2][3]. You can verify this compatibility in the official package documentation and the project's changelog, which confirms that the 15.0.0 release was a backport targeting Angular 15 [1][4]. Note that as of May 2026, the maintainers only actively support the latest three versions of the library [1][2].Citations:
Update
@angular-slider/ngx-sliderto version 15.x for Angular 15 compatibility.The current version
^14.0.0is not compatible with Angular 15. The library provides version 15.x specifically designed for Angular 15 with RxJS 7.x support. Update the dependency to^15.0.0.🤖 Prompt for AI Agents