Skip to content

Phase 3: handle Civil ID image failures in candidate view#57

Open
its-amann wants to merge 1 commit into
BAWES-Universe:masterfrom
its-amann:bounty/issue-55-phase-3-staff-civil-id-ui
Open

Phase 3: handle Civil ID image failures in candidate view#57
its-amann wants to merge 1 commit into
BAWES-Universe:masterfrom
its-amann:bounty/issue-55-phase-3-staff-civil-id-ui

Conversation

@its-amann

@its-amann its-amann commented May 15, 2026

Copy link
Copy Markdown

/claim #55

This PR covers the staff-side Phase 3 UI fixes for BAWES-Universe/studenthub#55.

What changed

  • keep the candidate detail page usable when the detail request returns an empty or error response, and surface a local message instead of leaving the page blank
  • fix the back Civil ID section to render from candidate_civil_photo_back instead of reusing the front-photo condition
  • keep the Civil ID sections visible when the image request fails and show Civil ID image unavailable - request re-upload for missing or blocked assets
  • add focused regression coverage for the back-photo rendering condition, the missing-image flags, and the detail-load error path

Verification

  • npm ci --legacy-peer-deps
  • npx ng build --configuration development
  • npx tsc against a temporary spec-only config for candidate-view.page.spec.ts

Notes

  • The repo-wide ng test run is currently blocked by unrelated pre-existing spec import and typing failures in other files. I did not claim the full suite as passing.

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@its-amann has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 27 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: db65f376-8174-47f3-b831-d7cf59b24389

📥 Commits

Reviewing files that changed from the base of the PR and between 39a33ff and 4d0fb7e.

📒 Files selected for processing (3)
  • src/app/pages/logged-in/candidate/candidate-view/candidate-view.page.html
  • src/app/pages/logged-in/candidate/candidate-view/candidate-view.page.spec.ts
  • src/app/pages/logged-in/candidate/candidate-view/candidate-view.page.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@its-amann

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant