Skip to content

Guard staff candidate pending fields in sibling pages #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Guard staff candidate pending fields in sibling pages #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/models/candidate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class Candidate {
candidateTags: CandidateTag[];
candidateIdCard: CandidateIdCard;
notes: Note[];
pendingField: any[];
pendingField: any[] | null;
certificates: CandidateCertificate[];
candidateStats: any;
candidateLinks: CandidateLink[];
Expand Down
3 changes: 2 additions & 1 deletion src/app/pages/logged-in/candidate/candidate-invitations/candidate-invitations.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ export class CandidateInvitationsPage implements OnInit {
this.loading = false;
this.candidate = response;
if(this.candidate){
this.candidate.pendingField = this.candidate?.pendingField?.filter(v => v != "experience")
const pendingField = Array.isArray(this.candidate.pendingField) ? this.candidate.pendingField : [];
this.candidate.pendingField = pendingField.filter(v => v != "experience");
this.candidate.isProfileCompleted = this.candidate.pendingField.length == 0;
}
});
Expand Down
3 changes: 2 additions & 1 deletion src/app/pages/logged-in/candidate/candidate-notes/candidate-notes.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ export class CandidateNotesPage implements OnInit {

this.candidate = response;
if(this.candidate){
this.candidate.pendingField = this.candidate?.pendingField?.filter(v => v != "experience")
const pendingField = Array.isArray(this.candidate.pendingField) ? this.candidate.pendingField : [];
this.candidate.pendingField = pendingField.filter(v => v != "experience");
this.candidate.isProfileCompleted = this.candidate.pendingField.length == 0;
}
});
Expand Down
3 changes: 2 additions & 1 deletion src/app/pages/logged-in/candidate/candidate-salary-list/candidate-salary-list.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export class CandidateSalaryListPage implements OnInit {
this.loading = false;
this.candidate = response;
if(this.candidate){
this.candidate.pendingField = this.candidate?.pendingField?.filter(v => v != "experience")
const pendingField = Array.isArray(this.candidate.pendingField) ? this.candidate.pendingField : [];
this.candidate.pendingField = pendingField.filter(v => v != "experience");
this.candidate.isProfileCompleted = this.candidate.pendingField.length == 0;
}

Expand Down
3 changes: 2 additions & 1 deletion src/app/pages/logged-in/candidate/candidate-suggestions/candidate-suggestions.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ export class CandidateSuggestionsPage implements OnInit {
this.loading = false;
this.candidate = response;
if(this.candidate){
this.candidate.pendingField = this.candidate?.pendingField?.filter(v => v != "experience")
const pendingField = Array.isArray(this.candidate.pendingField) ? this.candidate.pendingField : [];
this.candidate.pendingField = pendingField.filter(v => v != "experience");
this.candidate.isProfileCompleted = this.candidate.pendingField.length == 0;
}
});
Expand Down
3 changes: 2 additions & 1 deletion src/app/pages/logged-in/candidate/candidate-warning-list/candidate-warning-list.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ export class CandidateWarningsPage implements OnInit {
this.loading = false;
this.candidate = response;
if(this.candidate){
this.candidate.pendingField = this.candidate?.pendingField?.filter(v => v != "experience")
const pendingField = Array.isArray(this.candidate.pendingField) ? this.candidate.pendingField : [];
this.candidate.pendingField = pendingField.filter(v => v != "experience");
this.candidate.isProfileCompleted = this.candidate.pendingField.length == 0;
}
});
Expand Down