fix(portal): mark disabled Jobs board as setup required - #172
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Portal “Jobs” computed board to distinguish an expected “not configured yet” condition from genuine outages by returning a dedicated setup_required state when no Jobs scope mode is configured, and rendering a setup guide in the UI for that state. This keeps the existing behavior for real Kubernetes access / query failures.
Changes:
- Return
state: "setup_required"(with a setup-oriented reason) when Jobs scope mode is disabled/unset. - Extend the frontend
fetchJSONerror handling to preservestatusandstatefrom scoped JSON error envelopes. - Render a “Jobs board setup required” guide (instead of an outage-style warning) when receiving the
setup_requiredstate; update tests accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
portal/internal/portalapi/server.go |
Emits a setup_required state for the disabled Jobs board gate via writeScopedJSON. |
portal/internal/portalapi/server_test.go |
Updates expectations to assert the new reason text and that the disabled response includes "state":"setup_required", and verifies the portal shell contains the new UI contract strings. |
portal/internal/portalapi/assets/index.html |
Propagates status/state on thrown fetch errors and renders a setup guide for 503 + setup_required. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation