Skip to content

fix: Multi arch docker build #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hilariocoelho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Multi arch docker build #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
FROM scratch

# Build arguments for multi-architecture support
ARG TARGETARCH=amd64
ARG TARGETOS
ARG TARGETARCH
Copy link
Copy Markdown
Contributor

@weinong weinong Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add default os and arch?

Copy link
Copy Markdown
Author

@hilariocoelho hilariocoelho Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean exactly with "default os and arch"? Those built arguments are already filled on docker buildx by specifying --platform argument (ie: docker build . --platform linux/amd64 --platform linux/arm64).

When setting ARG TARGETARCH=amd64, only amd64 binary is being included on both containers (linux/amd64 and linux/arm64).

On the github action it is already prepared for linux/amd64 and linux/arm64

ARG VERSION=""

# OpenContainers Image Spec labels
Expand All @@ -19,7 +20,7 @@ LABEL org.opencontainers.image.licenses="MIT"
LABEL org.opencontainers.image.version="${VERSION}"

# Copy the pre-built binary from local build to /usr/local/bin
COPY bin/linux_${TARGETARCH}/kubelogin /usr/local/bin/kubelogin
COPY bin/${TARGETOS}_${TARGETARCH}/kubelogin /usr/local/bin/kubelogin

# Set the entrypoint
ENTRYPOINT ["/usr/local/bin/kubelogin"]
ENTRYPOINT ["/usr/local/bin/kubelogin"]