fix: honor provider batch max size#1755
Draft
comtalyst wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
comtalyst
force-pushed
the
eukritos/provider-batch-max-size-hard-cap
branch
from
f9c8562 to
f9cd0e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(AI-generated)
Description
Honor the provider batch max size as a hard cap. When a same-key batch is already full and another request arrives before the background loop drains it, enqueue dispatches the full batch and places the new request in a fresh batch. This prevents same-key instance create bursts from producing one provider header batch larger than configured.
How was this change tested?
go test ./pkg/utils/batcher ./pkg/providers/azclient/aksmachinesheaderbatch -count=1Does this change impact docs?
Release Note