fix: normalize CSI empty-zone topology value to regional zone "0"#1735
Open
andyzhangx wants to merge 1 commit into
Open
fix: normalize CSI empty-zone topology value to regional zone "0"#1735andyzhangx wants to merge 1 commit into
andyzhangx wants to merge 1 commit into
Conversation
Register a NormalizedLabelValues mapping so that when the Azure Disk CSI topology key (topology.disk.csi.azure.com/zone) is normalized to the well-known topology key (topology.kubernetes.io/zone), the empty string value used by the CSI driver for non-zonal disks is translated to "0" (the fault domain value cloud-provider-azure assigns to regional VMs). Without this translation, PVs with topology.disk.csi.azure.com/zone="" are normalized to topology.kubernetes.io/zone="" which does not match any Karpenter offering (regional offerings use zone="0"), causing pods with non-zonal PVCs to remain permanently pending. Depends on: kubernetes-sigs/karpenter#3104 (NormalizedLabelValues support)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register a
NormalizedLabelValuesmapping so that when the Azure Disk CSI topology key (topology.disk.csi.azure.com/zone) is normalized to the well-known topology key (topology.kubernetes.io/zone), the empty string value ("") used by the CSI driver for non-zonal disks is translated to"0"(the fault domain value cloud-provider-azure assigns to regional VMs).Problem
When the Azure Disk CSI driver creates a PV for a non-zonal (regional) disk, it sets:
Karpenter normalizes this key to
topology.kubernetes.io/zonebut preserves the value"". However, regional nodes in Karpenter offerings use zone value"0"(from cloud-provider-azure). This mismatch causes"" ∉ {"0"}→ no offering matches → pods with non-zonal PVCs remain permanently pending.Fix
Add value normalization in
init()using the newNormalizedLabelValuesAPI:Dependencies
NormalizedLabelValuessupport to karpenter-core