Skip to content

test: reuse acceptance tests across Scriptless and Machine API modes#1718

Open
comtalyst wants to merge 4 commits into
comtalyst/test-reunification-v3-renamesfrom
comtalyst/test-reunification-v3
Open

test: reuse acceptance tests across Scriptless and Machine API modes#1718
comtalyst wants to merge 4 commits into
comtalyst/test-reunification-v3-renamesfrom
comtalyst/test-reunification-v3

Conversation

@comtalyst

Copy link
Copy Markdown
Collaborator

Existing acceptance test infrastructure tests Scriptless and AKS Machine API modes with different set of tests.
This may result in unintended branch-out between two modes. Instead, the tests could be shared with by-design differences reflected in the test implementation.
With the direction being to extend the support of non-machine modes, this reasoning is holding more weight.

In this PR, we share the test primarily by:

  • Extending the AKS Machine API tests in cloudprovider module to be compatible with Scriptless
    • E.g., the ones that are validating AKS Machine API calls will validate CRP calls instead for non-machine modes
  • Move non-machine acceptance tests in instancetype to cloudprovider module, given the tests are testing end-to-end provisioning rather than instancetype's specific functionality.
  • Either merge them with existing AKS Machine API tests, or extend it to be compatible with AKS Machine API modes
  • Run the same suites of test on multiple context, where each context setup a mode

Fixes #

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


comtalyst and others added 4 commits June 6, 2026 04:10
Thread the existing test timeout into the Ginkgo package run and clean up lint issues from the shared test registration changes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant