test: reuse acceptance tests across Scriptless and Machine API modes#1718
Open
comtalyst wants to merge 4 commits into
Open
test: reuse acceptance tests across Scriptless and Machine API modes#1718comtalyst wants to merge 4 commits into
comtalyst wants to merge 4 commits into
Conversation
Thread the existing test timeout into the Ginkgo package run and clean up lint issues from the shared test registration changes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing acceptance test infrastructure tests Scriptless and AKS Machine API modes with different set of tests.
This may result in unintended branch-out between two modes. Instead, the tests could be shared with by-design differences reflected in the test implementation.
With the direction being to extend the support of non-machine modes, this reasoning is holding more weight.
In this PR, we share the test primarily by:
cloudprovidermodule to be compatible with Scriptlessinstancetypetocloudprovidermodule, given the tests are testing end-to-end provisioning rather thaninstancetype's specific functionality.Fixes #
Description
How was this change tested?
Does this change impact docs?
Release Note