-
Notifications
You must be signed in to change notification settings - Fork 131
chore: block setting kubernetes.azure.com taints #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthchr
wants to merge
1
commit into
Azure:main
Choose a base branch
from
matthchr:matthchr/kubernetes-azure-com-taint-restrictions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| #!/bin/bash | ||
| set -euo pipefail | ||
|
|
||
| # taints validation for nodeclaim and nodepool | ||
| # checking for restricted taint keys while filtering out well known taints | ||
|
|
||
| rule=$'!self.startsWith("kubernetes.azure.com/") || self == "kubernetes.azure.com/scalesetpriority" | ||
| ' | ||
| # above regex: everything before the first '/' (any characters except '/' at the beginning of the string) | ||
|
|
||
| rule=${rule//\"/\\\"} # escape double quotes | ||
| rule=${rule//$'\n'/} # remove newlines | ||
| rule=$(echo "$rule" | tr -s ' ') # remove extra spaces | ||
|
|
||
| # check that .spec.versions has 1 entry | ||
| [[ $(yq e '.spec.versions | length' pkg/apis/crds/karpenter.sh_nodepools.yaml) -eq 1 ]] || { echo "expected one version"; exit 1; } | ||
| [[ $(yq e '.spec.versions | length' pkg/apis/crds/karpenter.sh_nodeclaims.yaml) -eq 1 ]] || { echo "expected one version"; exit 1; } | ||
|
|
||
| # Add maxLength to taint key fields (required for CEL cost estimation with string operations) | ||
| # Using 316 to match the maxLength used for requirement keys (253 prefix + '/' + 63 name) | ||
| yq eval '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.startupTaints.items.properties.key.maxLength = 316' -i pkg/apis/crds/karpenter.sh_nodeclaims.yaml | ||
| yq eval '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.taints.items.properties.key.maxLength = 316' -i pkg/apis/crds/karpenter.sh_nodeclaims.yaml | ||
| yq eval '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.template.properties.spec.properties.startupTaints.items.properties.key.maxLength = 316' -i pkg/apis/crds/karpenter.sh_nodepools.yaml | ||
| yq eval '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.template.properties.spec.properties.taints.items.properties.key.maxLength = 316' -i pkg/apis/crds/karpenter.sh_nodepools.yaml | ||
|
|
||
| # Add maxItems to taint arrays (required for CEL cost estimation to bound per-item rule cost) | ||
| yq eval '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.startupTaints.maxItems = 100' -i pkg/apis/crds/karpenter.sh_nodeclaims.yaml | ||
| yq eval '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.taints.maxItems = 100' -i pkg/apis/crds/karpenter.sh_nodeclaims.yaml | ||
| yq eval '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.template.properties.spec.properties.startupTaints.maxItems = 100' -i pkg/apis/crds/karpenter.sh_nodepools.yaml | ||
| yq eval '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.template.properties.spec.properties.taints.maxItems = 100' -i pkg/apis/crds/karpenter.sh_nodepools.yaml | ||
|
|
||
| # nodeclaim - startupTaints | ||
| printf -v expr '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.startupTaints.items.properties.key.x-kubernetes-validations += | ||
| [{"message": "taint domain \\"kubernetes.azure.com\\" is restricted", "rule": "%s"}]' "$rule" | ||
| yq eval "${expr}" -i pkg/apis/crds/karpenter.sh_nodeclaims.yaml | ||
|
|
||
| # nodeclaim - taints | ||
| printf -v expr '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.taints.items.properties.key.x-kubernetes-validations += | ||
| [{"message": "taint domain \\"kubernetes.azure.com\\" is restricted", "rule": "%s"}]' "$rule" | ||
| yq eval "${expr}" -i pkg/apis/crds/karpenter.sh_nodeclaims.yaml | ||
|
|
||
| # nodepool - startupTaints | ||
| printf -v expr '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.template.properties.spec.properties.startupTaints.items.properties.key.x-kubernetes-validations += | ||
| [{"message": "taint domain \\"kubernetes.azure.com\\" is restricted", "rule": "%s"}]' "$rule" | ||
| yq eval "${expr}" -i pkg/apis/crds/karpenter.sh_nodepools.yaml | ||
|
|
||
| # nodepool - taints | ||
| printf -v expr '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.template.properties.spec.properties.taints.items.properties.key.x-kubernetes-validations += | ||
| [{"message": "taint domain \\"kubernetes.azure.com\\" is restricted", "rule": "%s"}]' "$rule" | ||
| yq eval "${expr}" -i pkg/apis/crds/karpenter.sh_nodepools.yaml | ||
|
|
||
| # Value validation: kubernetes.azure.com/scalesetpriority taint must have value "spot" | ||
| value_rule='self.key != \"kubernetes.azure.com/scalesetpriority\" || self.value == \"spot\"' | ||
|
|
||
| # nodeclaim - startupTaints (item-level) | ||
| printf -v expr '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.startupTaints.items.x-kubernetes-validations += | ||
| [{"message": "taint \\"kubernetes.azure.com/scalesetpriority\\" must have value \\"spot\\"", "rule": "%s"}]' "$value_rule" | ||
| yq eval "${expr}" -i pkg/apis/crds/karpenter.sh_nodeclaims.yaml | ||
|
|
||
| # nodeclaim - taints (item-level) | ||
| printf -v expr '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.taints.items.x-kubernetes-validations += | ||
| [{"message": "taint \\"kubernetes.azure.com/scalesetpriority\\" must have value \\"spot\\"", "rule": "%s"}]' "$value_rule" | ||
| yq eval "${expr}" -i pkg/apis/crds/karpenter.sh_nodeclaims.yaml | ||
|
|
||
| # nodepool - startupTaints (item-level) | ||
| printf -v expr '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.template.properties.spec.properties.startupTaints.items.x-kubernetes-validations += | ||
| [{"message": "taint \\"kubernetes.azure.com/scalesetpriority\\" must have value \\"spot\\"", "rule": "%s"}]' "$value_rule" | ||
| yq eval "${expr}" -i pkg/apis/crds/karpenter.sh_nodepools.yaml | ||
|
|
||
| # nodepool - taints (item-level) | ||
| printf -v expr '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.template.properties.spec.properties.taints.items.x-kubernetes-validations += | ||
| [{"message": "taint \\"kubernetes.azure.com/scalesetpriority\\" must have value \\"spot\\"", "rule": "%s"}]' "$value_rule" | ||
| yq eval "${expr}" -i pkg/apis/crds/karpenter.sh_nodepools.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.