-
Notifications
You must be signed in to change notification settings - Fork 469
Pipelines access key vault and storage through private endpoints #7483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yophilav
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of SFI work, we have to ensure that Azure resources used by our tests--specifically key vaults and storage accounts--are not open to the public internet. To complete the SFI work, we needed to make some updates to our test infrastructure. Specifically, this change ensures we only access key vaults from Azure Virtual Networks (vnets) so that we can use Private Link and private endpoints. This required that we move key vault access out of jobs that run from on-prem agents (e.g., Raspberry Pis used to test arm32v7 support). Note that we already take this approach when it comes to accessing storage accounts.
There was also a bit of refactoring involved so that we could optionally do the key vault access from a standalone job that always runs in Azure. In the pipelines that require it, we leveraged an existing job that generates a SAS token for accessing the test storage account.
To test, I ran the affected pipelines to ensure they pass:
CI build
CI test
Connectivity tests
End-to-end tests
Nested end-to-end tests
ISA-95 smoke tests
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines