Skip to content

Clear executionID when recovering from orphaned entities #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clear executionID when recovering from orphaned entities #1128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/DurableTask.Core/Entities/ClientEntityHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ public static EntityMessageEvent EmitUnlockForOrphanedLock(OrchestrationInstance
Id = "fix-orphaned-lock", // we don't know the original id but it does not matter
};

// Since entities are always calling continue-as-new (which changes the executionID), we need to clear it.
// By clearing it, we ensure the event is received by the current entity execution.
targetInstance.ExecutionId = null;
return new EntityMessageEvent(EntityMessageEventNames.ReleaseMessageEventName, message, targetInstance);
}

Expand Down