Update verifiy-links if block#16216
Merged
chidozieononiwu merged 1 commit intoJun 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the verify-links job condition in the verify-links GitHub Actions workflow to make the job’s execution criteria clearer and to explicitly allow execution on pull_request, workflow_dispatch, and constrained check_run events (Azure Pipelines + repo/name filters).
Changes:
- Adds explicit
github.event_namechecks forpull_requestandworkflow_dispatch. - Re-groups
check_runlogic so the “Azure Pipelines” app constraint applies to all repo/name combinations. - Improves readability/correctness of the boolean logic via explicit parentheses.
This was referenced Jun 27, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
7fbf3f8 to
1c276df
Compare
chidozieononiwu
added a commit
to Azure/azure-sdk-for-rust
that referenced
this pull request
Jun 27, 2026
…4673) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16216 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
chidozieononiwu
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jun 27, 2026
…39109) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16216 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the workflow conditions in
.github/workflows/verify-links.ymlto improve when the "Verify Links" job runs. The main change is expanding the logic so that the job is triggered not only for pull requests and manual dispatches, but also for certaincheck_runevents, with more precise grouping and evaluation.Workflow trigger logic improvements:
ifcondition for theverify-linksjob to:pull_requestandworkflow_dispatchevents.check_runevent logic to ensure the job only runs when the event is from "Azure Pipelines" and the repository and check run name match specific criteria, grouping these conditions for clarity and correctness. [1] [2]