Skip to content

Update verifiy-links if block#16216

Merged
chidozieononiwu merged 1 commit into
Azure:mainfrom
chidozieononiwu:test-link-verification-workflow
Jun 27, 2026
Merged

Update verifiy-links if block#16216
chidozieononiwu merged 1 commit into
Azure:mainfrom
chidozieononiwu:test-link-verification-workflow

Conversation

@chidozieononiwu

Copy link
Copy Markdown
Member

This pull request updates the workflow conditions in .github/workflows/verify-links.yml to improve when the "Verify Links" job runs. The main change is expanding the logic so that the job is triggered not only for pull requests and manual dispatches, but also for certain check_run events, with more precise grouping and evaluation.

Workflow trigger logic improvements:

  • Updated the if condition for the verify-links job to:
    • Explicitly include both pull_request and workflow_dispatch events.
    • Refactor the check_run event logic to ensure the job only runs when the event is from "Azure Pipelines" and the repository and check run name match specific criteria, grouping these conditions for clarity and correctness. [1] [2]

Copilot AI review requested due to automatic review settings June 27, 2026 07:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the verify-links job condition in the verify-links GitHub Actions workflow to make the job’s execution criteria clearer and to explicitly allow execution on pull_request, workflow_dispatch, and constrained check_run events (Azure Pipelines + repo/name filters).

Changes:

  • Adds explicit github.event_name checks for pull_request and workflow_dispatch.
  • Re-groups check_run logic so the “Azure Pipelines” app constraint applies to all repo/name combinations.
  • Improves readability/correctness of the boolean logic via explicit parentheses.

Comment thread .github/workflows/verify-links.yml
@chidozieononiwu chidozieononiwu force-pushed the test-link-verification-workflow branch from 7fbf3f8 to 1c276df Compare June 27, 2026 07:37
chidozieononiwu added a commit to Azure/azure-sdk-for-rust that referenced this pull request Jun 27, 2026
…4673)

Sync .github/workflows directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#16216 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
chidozieononiwu added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 27, 2026
…39109)

Sync .github/workflows directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#16216 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
@chidozieononiwu chidozieononiwu merged commit 1d8eb70 into Azure:main Jun 27, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants