Skip to content

Switch pack flow to generate_api#4787

Open
heaths wants to merge 2 commits into
Azure:mainfrom
heaths:generate-api-version
Open

Switch pack flow to generate_api#4787
heaths wants to merge 2 commits into
Azure:mainfrom
heaths:generate-api-version

Conversation

@heaths

@heaths heaths commented Jul 15, 2026

Copy link
Copy Markdown
Member

Route Pack-Crates.ps1 through generate_api so packaged crates keep the
existing APIView artifact shape by default while exposing a temporary
-APIReview path for crate-root API.md generation.

Update the generate_api README to describe the current pipeline flow and
the temporary markdown testing path.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Copilot-Session: 666bbd92-9ac2-46b9-ba17-90e61a463272

Route Pack-Crates.ps1 through generate_api so packaged crates keep the
existing APIView artifact shape by default while exposing a temporary
-APIReview path for crate-root API.md generation.

Update the generate_api README to describe the current pipeline flow and
the temporary markdown testing path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 666bbd92-9ac2-46b9-ba17-90e61a463272
Copilot AI review requested due to automatic review settings July 15, 2026 23:55
@heaths
heaths requested a review from danieljurek as a code owner July 15, 2026 23:55
@heaths
heaths requested a review from chidozieononiwu July 15, 2026 23:55
@heaths
heaths requested a review from xirzec as a code owner July 15, 2026 23:55
@heaths
heaths requested a review from praveenkuttappan July 15, 2026 23:55
@heaths
heaths requested a review from RickWinter as a code owner July 15, 2026 23:55
@heaths
heaths requested a review from danieljurek July 15, 2026 23:55
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Routes crate packaging through generate_api and documents the updated API review workflow.

Changes:

  • Adds APIView and temporary Markdown generation paths.
  • Sets the generator version to 2.0.0.
  • Updates workflow documentation.
Show a summary per file
File Description
eng/scripts/Pack-Crates.ps1 Integrates generate_api into packaging.
eng/tools/generate_api/Cargo.toml Sets generator version.
eng/tools/generate_api/README.md Documents pipeline and local testing flows.

Review details

  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread eng/scripts/Pack-Crates.ps1
Use the Rust APIView token naming contract when staging generated review
files and update the Rust API review artifact finder to look for the
same `_rust.json` file name.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6b7c45e8-f2e6-4fb1-a24d-3aed4f9bb98e
Copilot AI review requested due to automatic review settings July 16, 2026 21:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread eng/tools/generate_api/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants