Skip to content

Cosmos: downgrade request-status error logs to debug #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Cosmos: downgrade request-status error logs to debug #4711

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6cd6a5
Initial plan
Copilot Jul 7, 2026
2f195c1
Lower Cosmos HTTP error logs to debug
Copilot Jul 7, 2026
dfb4a56
Merge branch 'main' into copilot/fix-cosmos-tracing-levels
analogrelay Jul 24, 2026
16ae25a
Refine hedge terminal tracing logs
Copilot Jul 24, 2026
74c6479
Update hedging spec and changelog
Copilot Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdk/cosmos/azure_data_cosmos_driver/src/driver/pipeline/operation_pipeline.rs
View file
Open in desktop

@NaluTripician NaluTripician Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a changelog entry here?

@NaluTripician NaluTripician Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I think this might introduce some conflict with the specs.

§10.4's level table and OTel-naming note are now partially contradicted.

Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ pub(crate) async fn execute_operation_pipeline(
retry_state.pending_write_effects.clear();
}

tracing::error!(
tracing::debug!(
Comment thread
analogrelay marked this conversation as resolved.
activity_id = %activity_id,
status = ?cosmos_status,
error = %error,
Expand Down Expand Up @@ -2443,12 +2443,12 @@ fn finalize_hedge_attempt(
body,
..
} => {
tracing::warn!(
tracing::debug!(
activity_id = %diagnostics.activity_id(),
request_count = diagnostics.request_count(),
http_status = u16::from(status.status_code()),
sub_status = ?status.sub_status(),
"cosmos.hedge.terminal_http_error",

@NaluTripician NaluTripician Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No migration note for anyone alerting on cosmos.hedge.terminal_http_error — string is gone. Breaking for log-based alerting, or never a supported surface? (§10.4 says "reserved," which cuts toward the latter.)

"non-retriable http error in hedging attempt",
);
let diagnostics_ctx = Arc::new(diagnostics.complete());
let base = build_service_error(&status, &cosmos_headers, &body);
Expand All @@ -2457,11 +2457,11 @@ fn finalize_hedge_attempt(
.build())
}
TransportOutcome::TransportError { error, .. } => {
tracing::warn!(
tracing::debug!(
activity_id = %diagnostics.activity_id(),
request_count = diagnostics.request_count(),
error = %error,
"cosmos.hedge.terminal_transport_error",
"non-retriable transport error in hedging attempt",
);
let diagnostics_ctx = Arc::new(diagnostics.complete());
Err(crate::error::CosmosErrorBuilder::from_error(error)
Expand All @@ -2472,7 +2472,7 @@ fn finalize_hedge_attempt(
tracing::warn!(
activity_id = %diagnostics.activity_id(),
request_count = diagnostics.request_count(),
"cosmos.hedge.terminal_deadline_exceeded",
"deadline exceeded in hedging attempt",
);
// Typed status (408 + CLIENT_OPERATION_TIMEOUT) mirrors
// `enforce_deadline_or_timeout` so retry-evaluation and
Expand Down
Loading