Skip to content

Conversation

heaths
Copy link
Member

@heaths heaths commented Oct 6, 2025

Fixes #3117 and fixes #3118 by renaming doc_auto_cfg and doc_cfg_hide to just doc_cfg after rust-lang/rust#138907 was merged and released in the new nightly toolchain docs.rs uses.

Fixes Azure#3117 and fixes Azure#3118 by renaming `doc_auto_cfg` and `doc_cfg_hide` to just `doc_cfg` after rust-lang/rust#138907 was merged and released in the new nightly toolchain docs.rs uses.
@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 19:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Rust documentation feature flag from doc_auto_cfg to doc_cfg following a merge of rust-lang/rust#138907. The change affects multiple core crates in the Azure SDK, requiring patch version bumps to maintain compatibility with the new Rust nightly toolchain used by docs.rs.

Key changes:

  • Replace doc_auto_cfg with doc_cfg feature flag across all affected crates
  • Bump patch versions for core crates that received the documentation fix
  • Update changelog entries to document the bug fix

Reviewed Changes

Copilot reviewed 34 out of 35 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/typespec/typespec_macros/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/typespec/typespec_client_core/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/typespec/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/storage/azure_storage_blob/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/servicebus/azure_messaging_servicebus/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/keyvault/azure_security_keyvault_secrets/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/keyvault/azure_security_keyvault_keys/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/keyvault/azure_security_keyvault_certificates/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/identity/azure_identity/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/eventhubs/azure_messaging_eventhubs/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/cosmos/azure_data_cosmos/src/lib.rs Replace deprecated features with doc_cfg and remove outdated comments
sdk/core/azure_core_opentelemetry/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/core/azure_core_macros/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/core/azure_core_amqp/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/core/azure_core/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
sdk/canary/azure_canary_core/src/lib.rs Replace deprecated doc_auto_cfg feature with doc_cfg
Various Cargo.toml files Bump patch versions for affected core crates
Various CHANGELOG.md files Add changelog entries documenting the documentation fix
eng/scripts/Analyze-Code.ps1 Add nightly toolchain support for cargo-docs-rs testing
eng/pipelines/templates/jobs/analyze.yml Pass toolchain parameter to analysis script
Cargo.toml Update workspace dependency versions to match patch bumps

@github-actions github-actions bot added Azure.Core The azure_core crate Azure.Identity The azure_identity crate Cosmos The azure_cosmos crate KeyVault Key Vault Storage Storage Service (Queues, Blobs, Files) labels Oct 6, 2025
@heaths heaths merged commit 9fbbc1c into Azure:main Oct 6, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure SDK for Key Vault Oct 6, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure Identity SDK Improvements Oct 6, 2025
@heaths heaths deleted the issue3118 branch October 6, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core The azure_core crate Azure.Identity The azure_identity crate Cosmos The azure_cosmos crate KeyVault Key Vault Storage Storage Service (Queues, Blobs, Files)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

docs.rs failing to build recently published crates Add cargo-docs-rs back into PR/CI testing
4 participants