Add the test-proxy client #2000
Merged
+1,360
−420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Azure#1875. I was unable to generate it from the TypeSpec because we lack support for a few things in the emitter, but I rename (hid as dotfile) the tsp-location.yaml for future use and easy reference for anyone wanting to know how.
heaths
requested review from
JeffreyRichter,
LarryOsterman and
ronniegeraghty
as code owners
|
Note that this is only the test-proxy client. I have subsequent tasks to wire everything up but this was enough code - and specific to a single task - that I wanted to get eyes on it. I'll continue on a separate branch and rebase --onto later. Like Go's, thish does not define every single method that test-proxy defines because I don't think we'll need them; however, should we, I'll add them as needed. Think of this more as an MVP with legs. |
Like the rest of the test-proxy, we can't use it on the wasm32 architecture because `Proxy` can't support it. Anything that uses proxy could use a mock, but we already don't compile `#[recorded::test]` tests for wasm32 so there's no point currently.
After talking with @scbedd I made a couple changes to be *practically* correct w.r.t. testing client libraries outside perf testing as corner cases e.g., *requiring* `x-recording-file` when starting recording or playback.
LarryOsterman
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1875. I was unable to generate it from the TypeSpec because we lack support for a few things in the emitter, but I rename (hid as dotfile) the tsp-location.yaml for future use and easy reference for anyone wanting to know how.