Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new response struct for AppendBlock, exposing ETag, blob_append_offset and blob_committed_block_count #1965

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Create new response struct for AppendBlock, exposing ETag, blob_append_offset and blob_committed_block_count #1965

merged 3 commits into from
Jan 10, 2025

Conversation

LeonHartley
Copy link

Fixes #1964

@LeonHartley
Copy link
Author

@LeonHartley please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@LeonHartley
Copy link
Author

@heaths @RickWinter @JeffreyRichter @ronniegeraghty ping :)

heaths
heaths approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

LGTM, but keep in mind we have no plans to release subsequent versions from the legacy branch at this time. The Storage team is working on supported crates out of the main branch. /cc @vincenttran-msft to make sure proper support is included for this.

@LeonHartley you might consider patching your dependency on this in your Cargo.toml manifest.

@heaths heaths enabled auto-merge (squash) January 10, 2025 21:09
@heaths heaths merged commit dce289d into Azure:legacy Jan 10, 2025
17 of 22 checks passed
arpad-m pushed a commit to neondatabase/azure-sdk-for-rust that referenced this pull request Feb 14, 2025
@LeonHartley @arpad-m
Create new response struct for AppendBlock, exposing ETag, blob_appen…
ad9b4fc 
…d_offset and blob_committed_block_count (Azure#1965)

* Create bespoke response struct for AppendBlock operation exposing ETag

* Expose blob_append_offset and blob_commited_block_count

* Cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@JeffreyRichter JeffreyRichter Awaiting requested review from JeffreyRichter JeffreyRichter is a code owner

@ronniegeraghty ronniegeraghty Awaiting requested review from ronniegeraghty ronniegeraghty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeonHartley @heaths