[Storage] Fix 103/104 Live Test Failures - #48376
Conversation
|
/azp run python - storage - tests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
1 similar comment
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Updates Blob Arrow live tests to allow an optional last_accessed_on value while still validating timezone information when present.
Changes:
- Relax synchronous and asynchronous blob metadata assertions consistently.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sdk/storage/azure-storage-blob/tests/test_arrow.py |
Handles absent last-access timestamps. |
sdk/storage/azure-storage-blob/tests/test_arrow_async.py |
Applies equivalent asynchronous test behavior. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (4)
sdk/storage/azure-storage-file-share/tests/test_file.py:2839
NO_PENDING_COPY_OPERATIONonly proves that the operation has ended; it does not prove that it finished successfully. If the OAuth copy fails before this abort request, this branch now treats that real live-test failure as a pass. Verify the final copy status and data in this race path instead of accepting every ended operation.
except HttpResponseError as e:
assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION
sdk/storage/azure-storage-file-share/tests/test_file_async.py:2900
NO_PENDING_COPY_OPERATIONonly proves that the operation has ended; it does not prove that it finished successfully. If the OAuth copy fails before this abort request, this branch now treats that real live-test failure as a pass. Verify the final copy status and data in this race path instead of accepting every ended operation.
except HttpResponseError as e:
assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION
sdk/storage/azure-storage-file-share/tests/test_file.py:2785
NO_PENDING_COPY_OPERATIONonly proves that the operation has ended; it does not prove that it finished successfully. If the remote copy fails before this abort request, this branch now treats that real live-test failure as a pass. Verify the final copy status and data in this race path instead of accepting every ended operation.
This issue also appears on line 2838 of the same file.
except HttpResponseError as e:
assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION
sdk/storage/azure-storage-file-share/tests/test_file_async.py:2844
NO_PENDING_COPY_OPERATIONonly proves that the operation has ended; it does not prove that it finished successfully. If the remote copy fails before this abort request, this branch now treats that real live-test failure as a pass. Verify the final copy status and data in this race path instead of accepting every ended operation.
This issue also appears on line 2899 of the same file.
except HttpResponseError as e:
assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION
|
/azp run python - storage - tests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
[Pilot] PR Pipeline Failure AnalysisA CI pipeline failed on this pull request. Here is an automated analysis of what went wrong and how to get the build green. What failedThe same two tests failed consistently across all platforms (Ubuntu 24.04 Python 3.10/3.13/3.14, macOS Python 3.11, Windows 2022 Python 3.12) and all install modes (whl, sdist, mindependency):
Category: test failure. The failures are reproducible across every OS/Python-version combination and all three install modes, which strongly suggests the tests are asserting behavior that this PR's code changes have affected (or a service-side response changed). The PR description notes "the other tests should not be failing," indicating these failures may be unintended regressions. Recommended next steps
Raw pipeline analysis (azsdk ci analyze)
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Suppressed comments (4)
sdk/storage/azure-storage-file-share/tests/test_file.py:2839
NoPendingCopyOperationalso occurs when an asynchronous copy has ended in a failed state, so checking only this error code can turn a real copy failure into a passing test. Confirm the completed target and its contents before treating the exception as the benign completion race.
except HttpResponseError as e:
assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION
sdk/storage/azure-storage-file-share/tests/test_file_async.py:2900
- A completed failed copy can also cause
abort_copyto returnNoPendingCopyOperation, so this assertion alone lets that failure pass. Verify that this race ended with a successful copy and the expected content.
except HttpResponseError as e:
assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION
sdk/storage/azure-storage-file-share/tests/test_file.py:2785
NoPendingCopyOperationonly proves that the copy is no longer pending; an asynchronously failed copy produces the same abort error. As written, that failure path now passes the test. Verify that the target completed successfully (and contains the source data) before accepting this as the expected race.
This issue also appears on line 2838 of the same file.
except HttpResponseError as e:
assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION
sdk/storage/azure-storage-file-share/tests/test_file_async.py:2844
NoPendingCopyOperationonly indicates that the operation has ended; it does not distinguish a successful completion from a failed copy. This branch therefore masks failed-copy regressions. Check the target status and copied bytes before accepting the race.
This issue also appears on line 2899 of the same file.
except HttpResponseError as e:
assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION
|
/azp run python - storage - tests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
f5033d5
into
Azure:main
Will still expect smart tiers to fail, but the other tests should not be failing.