Skip to content

[Storage] Fix 103/104 Live Test Failures - #48376

Merged
Peter Wu (weirongw23-msft) merged 6 commits into
Azure:mainfrom
weirongw23-msft:weirongw23/103-104-fixes
Jul 31, 2026
Merged

[Storage] Fix 103/104 Live Test Failures#48376
Peter Wu (weirongw23-msft) merged 6 commits into
Azure:mainfrom
weirongw23-msft:weirongw23/103-104-fixes

Conversation

@weirongw23-msft

Copy link
Copy Markdown
Member

Will still expect smart tiers to fail, but the other tests should not be failing.

@weirongw23-msft
Peter Wu (weirongw23-msft) marked this pull request as ready for review July 30, 2026 17:34
Copilot AI review requested due to automatic review settings July 30, 2026 17:34
@weirongw23-msft

Copy link
Copy Markdown
Member Author

/azp run python - storage - tests

@github-actions github-actions Bot added the Storage Storage Service (Queues, Blobs, Files) label Jul 30, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Blob Arrow live tests to allow an optional last_accessed_on value while still validating timezone information when present.

Changes:

  • Relax synchronous and asynchronous blob metadata assertions consistently.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/storage/azure-storage-blob/tests/test_arrow.py Handles absent last-access timestamps.
sdk/storage/azure-storage-blob/tests/test_arrow_async.py Applies equivalent asynchronous test behavior.

Copilot AI review requested due to automatic review settings July 30, 2026 18:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (4)

sdk/storage/azure-storage-file-share/tests/test_file.py:2839

  • NO_PENDING_COPY_OPERATION only proves that the operation has ended; it does not prove that it finished successfully. If the OAuth copy fails before this abort request, this branch now treats that real live-test failure as a pass. Verify the final copy status and data in this race path instead of accepting every ended operation.
        except HttpResponseError as e:
            assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION

sdk/storage/azure-storage-file-share/tests/test_file_async.py:2900

  • NO_PENDING_COPY_OPERATION only proves that the operation has ended; it does not prove that it finished successfully. If the OAuth copy fails before this abort request, this branch now treats that real live-test failure as a pass. Verify the final copy status and data in this race path instead of accepting every ended operation.
        except HttpResponseError as e:
            assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION

sdk/storage/azure-storage-file-share/tests/test_file.py:2785

  • NO_PENDING_COPY_OPERATION only proves that the operation has ended; it does not prove that it finished successfully. If the remote copy fails before this abort request, this branch now treats that real live-test failure as a pass. Verify the final copy status and data in this race path instead of accepting every ended operation.

This issue also appears on line 2838 of the same file.

        except HttpResponseError as e:
            assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION

sdk/storage/azure-storage-file-share/tests/test_file_async.py:2844

  • NO_PENDING_COPY_OPERATION only proves that the operation has ended; it does not prove that it finished successfully. If the remote copy fails before this abort request, this branch now treats that real live-test failure as a pass. Verify the final copy status and data in this race path instead of accepting every ended operation.

This issue also appears on line 2899 of the same file.

        except HttpResponseError as e:
            assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION

@weirongw23-msft

Copy link
Copy Markdown
Member Author

/azp run python - storage - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI review requested due to automatic review settings July 30, 2026 20:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@github-actions

Copy link
Copy Markdown
Contributor
[Pilot] PR Pipeline Failure Analysis

A CI pipeline failed on this pull request. Here is an automated analysis of what went wrong and how to get the build green.

What failed

The same two tests failed consistently across all platforms (Ubuntu 24.04 Python 3.10/3.13/3.14, macOS Python 3.11, Windows 2022 Python 3.12) and all install modes (whl, sdist, mindependency):

  • sdk.storage.azure-storage-blob.tests.test_arrow.TestStorageApacheArrow.test_arrow_list_blobs_include_versions
  • sdk.storage.azure-storage-blob.tests.test_arrow_async.TestStorageApacheArrowAsync.test_arrow_list_blobs_include_versions

Category: test failure. The failures are reproducible across every OS/Python-version combination and all three install modes, which strongly suggests the tests are asserting behavior that this PR's code changes have affected (or a service-side response changed). The PR description notes "the other tests should not be failing," indicating these failures may be unintended regressions.

Recommended next steps

  • Investigate test_arrow_list_blobs_include_versions (sync and async) in sdk/storage/azure-storage-blob/tests/ — check what assertion is failing and whether it's related to the 103/104 fixes introduced by this PR.
  • Run the tests locally against a live or recorded endpoint to reproduce and diagnose the failure.
  • If the test expectations need updating to match new correct behavior, update the test recordings and/or assertions accordingly.
  • If these failures are pre-existing and unrelated to this PR, consider filing a separate issue and skipping/xfailing the tests with a tracking comment.
  • See the CI troubleshooting guide: https://aka.ms/ci-fix
  • Push new commits to address the failures; this comment updates automatically on the next failing run.
Raw pipeline analysis (azsdk ci analyze)
Analyzing pipeline https://github.com/Azure/azure-sdk-for-python/pull/48376...
--------------------------------------------------------------------------------
Failed Tests
--------------------------------------------------------------------------------
{
  "LLM Artifacts - Ubuntu2404_313": [
    "sdk.storage.azure-storage-blob.tests.test_arrow.TestStorageApacheArrow.test_arrow_list_blobs_include_versions",
    "sdk.storage.azure-storage-blob.tests.test_arrow_async.TestStorageApacheArrowAsync.test_arrow_list_blobs_include_versions"
  ],
  "LLM Artifacts - macos311": [
    "sdk.storage.azure-storage-blob.tests.test_arrow.TestStorageApacheArrow.test_arrow_list_blobs_include_versions",
    "sdk.storage.azure-storage-blob.tests.test_arrow_async.TestStorageApacheArrowAsync.test_arrow_list_blobs_include_versions"
  ],
  "LLM Artifacts - ubuntu2404_310": [
    "sdk.storage.azure-storage-blob.tests.test_arrow.TestStorageApacheArrow.test_arrow_list_blobs_include_versions",
    "sdk.storage.azure-storage-blob.tests.test_arrow_async.TestStorageApacheArrowAsync.test_arrow_list_blobs_include_versions"
  ],
  "LLM Artifacts - ubuntu2404_310_coverage": [
    "sdk.storage.azure-storage-blob.tests.test_arrow.TestStorageApacheArrow.test_arrow_list_blobs_include_versions",
    "sdk.storage.azure-storage-blob.tests.test_arrow_async.TestStorageApacheArrowAsync.test_arrow_list_blobs_include_versions"
  ],
  "LLM Artifacts - Ubuntu2404_314": [
    "sdk.storage.azure-storage-blob.tests.test_arrow.TestStorageApacheArrow.test_arrow_list_blobs_include_versions",
    "sdk.storage.azure-storage-blob.tests.test_arrow_async.TestStorageApacheArrowAsync.test_arrow_list_blobs_include_versions"
  ],
  "LLM Artifacts - windows2022_312": [
    "sdk.storage.azure-storage-blob.tests.test_arrow.TestStorageApacheArrow.test_arrow_list_blobs_include_versions",
    "sdk.storage.azure-storage-blob.tests.test_arrow_async.TestStorageApacheArrowAsync.test_arrow_list_blobs_include_versions"
  ]
}

Copilot detected the failing pipeline and generated the analysis above. To have it attempt a fix automatically, reply with @copilot please fix the failing pipeline on this PR.

Generated by Pipeline Analysis - Next Steps · 20.2 AIC · ⌖ 6.31 AIC · ⊞ 6.6K ·

Copilot AI review requested due to automatic review settings July 31, 2026 18:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Suppressed comments (4)

sdk/storage/azure-storage-file-share/tests/test_file.py:2839

  • NoPendingCopyOperation also occurs when an asynchronous copy has ended in a failed state, so checking only this error code can turn a real copy failure into a passing test. Confirm the completed target and its contents before treating the exception as the benign completion race.
        except HttpResponseError as e:
            assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION

sdk/storage/azure-storage-file-share/tests/test_file_async.py:2900

  • A completed failed copy can also cause abort_copy to return NoPendingCopyOperation, so this assertion alone lets that failure pass. Verify that this race ended with a successful copy and the expected content.
        except HttpResponseError as e:
            assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION

sdk/storage/azure-storage-file-share/tests/test_file.py:2785

  • NoPendingCopyOperation only proves that the copy is no longer pending; an asynchronously failed copy produces the same abort error. As written, that failure path now passes the test. Verify that the target completed successfully (and contains the source data) before accepting this as the expected race.

This issue also appears on line 2838 of the same file.

        except HttpResponseError as e:
            assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION

sdk/storage/azure-storage-file-share/tests/test_file_async.py:2844

  • NoPendingCopyOperation only indicates that the operation has ended; it does not distinguish a successful completion from a failed copy. This branch therefore masks failed-copy regressions. Check the target status and copied bytes before accepting the race.

This issue also appears on line 2899 of the same file.

        except HttpResponseError as e:
            assert e.error_code == StorageErrorCode.NO_PENDING_COPY_OPERATION

Copilot AI review requested due to automatic review settings July 31, 2026 18:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

@weirongw23-msft

Copy link
Copy Markdown
Member Author

/azp run python - storage - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@weirongw23-msft
Peter Wu (weirongw23-msft) merged commit f5033d5 into Azure:main Jul 31, 2026
35 of 50 checks passed
@weirongw23-msft
Peter Wu (weirongw23-msft) deleted the weirongw23/103-104-fixes branch July 31, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants