Refresh azure-mgmt-powerbidedicated after migrate to Typespec - #48323
Conversation
…osoft.PowerBIdedicated/PowerBIDedicated/tspconfig.yaml', API Version: 2021-01-01, SDK Release Type: stable, and CommitSHA: '801a60cdad2669e8f824fedfbabbfe7f7093b940' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6632102 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Refreshes the Power BI Dedicated management SDK from TypeSpec and promotes it to stable version 2.0.0.
Changes:
- Updates TypeSpec source and generator metadata.
- Promotes package metadata and version to stable 2.0.0.
- Refreshes generated API types, documentation, and APIView artifacts.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tsp-location.yaml |
Updates the specification commit. |
pyproject.toml |
Marks the package as stable. |
CHANGELOG.md |
Adds 2.0.0 release notes. |
types.py |
Removes obsolete generated typed dictionaries. |
_version.py |
Sets version 2.0.0. |
_utils/model_base.py |
Clarifies generated mapping docstrings. |
apiview-properties.json |
Updates the cross-language API version. |
api.metadata.yml |
Refreshes API snapshot metadata. |
api.md |
Updates the public API snapshot. |
_metadata.json |
Updates generation source and emitter versions. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
sdk/powerbidedicated/azure-mgmt-powerbidedicated/CHANGELOG.md:13
- This breaking-change note leaves users without a migration target even though the client was specifically renamed. The prior preview entry and the current README both identify
PowerBIDedicatedMgmtClient; state that exact rename here so users upgrading from the last stable release can update their imports.
- Deleted or renamed client `PowerBIDedicated`
✅ Live Test ResultsSummary: 8 passed, 8 warnings in 79.69s (0:01:19) |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
sdk/powerbidedicated/azure-mgmt-powerbidedicated/CHANGELOG.md:13
- The migration target is known, so this wording should identify it directly; “deleted or renamed” does not tell users how to update their code.
- Deleted or renamed client `PowerBIDedicated`
sdk/powerbidedicated/azure-mgmt-powerbidedicated/CHANGELOG.md:23
- This release also removes public TypedDict exports from
azure.mgmt.powerbidedicated.types, includingCheckCapacityNameAvailabilityResult, the operation/metric types, and both SKU enumeration result types, but the breaking-change notes do not disclose those removals. Document the removedtypesexports so users of the 1.x API have a complete migration path.
- Deleted model `AutoScaleVCoreListResult`/`DedicatedCapacities`/`OperationListResult` which actually were not used by SDK users
sdk/powerbidedicated/azure-mgmt-powerbidedicated/tests/conftest.py:21
- Correct the grammar in this security guidance.
# For security, please avoid record sensitive identity information in recordings
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (6)
sdk/powerbidedicated/azure-mgmt-powerbidedicated/tests/test_power_bi_dedicated_mgmt_operations_test.py:16
- This class is skipped in normal playback/CI runs:
sdk/conftest.py:41-47skips everylive_test_onlytest, and this package contains no recordings or other tests. As a result, neither the synchronous operations path nor this TypeSpec migration is exercised by CI. Record the test and remove the live-only marker, or add a deterministic mocked test that runs in CI.
@pytest.mark.live_test_only
sdk/powerbidedicated/azure-mgmt-powerbidedicated/tests/test_power_bi_dedicated_mgmt_operations_async_test.py:17
- This class is skipped in normal playback/CI runs:
sdk/conftest.py:41-47skips everylive_test_onlytest, and this package contains no recordings or other tests. Consequently, the asynchronous operations path is never exercised in CI. Record the test and remove the live-only marker, or add a deterministic mocked async test that runs in CI.
@pytest.mark.live_test_only
sdk/powerbidedicated/azure-mgmt-powerbidedicated/tests/test_power_bi_dedicated_mgmt_capacities_operations_async_test.py:17
- This class is skipped in normal playback/CI runs because
sdk/conftest.py:41-47skipslive_test_onlytests, and no recordings are included. The asynchronous capacities calls therefore provide no CI coverage for this migration. Record these tests and remove the live-only marker, or add deterministic mocked async coverage.
@pytest.mark.live_test_only
sdk/powerbidedicated/azure-mgmt-powerbidedicated/tests/test_power_bi_dedicated_mgmt_auto_scale_vcores_operations_test.py:16
- This class is skipped in normal playback/CI runs because
sdk/conftest.py:41-47skipslive_test_onlytests, and no recordings are included. The auto-scale vCore list path therefore has no CI coverage. Record this test and remove the live-only marker, or add a deterministic mocked test.
@pytest.mark.live_test_only
sdk/powerbidedicated/azure-mgmt-powerbidedicated/tests/test_power_bi_dedicated_mgmt_auto_scale_vcores_operations_async_test.py:17
- This class is skipped in normal playback/CI runs because
sdk/conftest.py:41-47skipslive_test_onlytests, and no recordings are included. The asynchronous auto-scale vCore list path therefore has no CI coverage. Record this test and remove the live-only marker, or add a deterministic mocked async test.
@pytest.mark.live_test_only
sdk/powerbidedicated/azure-mgmt-powerbidedicated/tests/test_power_bi_dedicated_mgmt_capacities_operations_test.py:16
- This class is skipped in normal playback/CI runs because
sdk/conftest.py:41-47skipslive_test_onlytests, and no recordings are included. The newly added capacities calls therefore provide no CI coverage for this migration. Record these tests and remove the live-only marker, or add deterministic mocked coverage.
@pytest.mark.live_test_only
Configurations: 'specification/powerbidedicated/resource-manager/Microsoft.PowerBIdedicated/PowerBIDedicated/tspconfig.yaml', API Version: 2021-01-01, SDK Release Type: stable, and CommitSHA: '801a60cdad2669e8f824fedfbabbfe7f7093b940' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6632102 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.