Refresh azure-mgmt-storagesync after migrate to Typespec - #48320
Conversation
….StorageSync/StorageSync/tspconfig.yaml', API Version: 2022-09-01, SDK Release Type: stable, and CommitSHA: '801a60cdad2669e8f824fedfbabbfe7f7093b940' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6632047 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Refreshes Storage Sync management SDK generation from the updated TypeSpec source and promotes version 2.0.0 to stable.
Changes:
- Updates TypeSpec generation metadata and emitter versions.
- Promotes package metadata and version to stable 2.0.0.
- Refreshes generated typing and APIView snapshots.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tsp-location.yaml |
Updates the specification commit. |
pyproject.toml |
Marks the package stable. |
CHANGELOG.md |
Documents 2.0.0 features and breaking changes. |
azure/mgmt/storagesync/types.py |
Refreshes generated type helpers. |
azure/mgmt/storagesync/_version.py |
Sets version 2.0.0. |
azure/mgmt/storagesync/_utils/model_base.py |
Refreshes generated docstrings. |
apiview-properties.json |
Updates cross-language API version metadata. |
api.metadata.yml |
Updates API snapshot metadata. |
api.md |
Refreshes the public API snapshot. |
_metadata.json |
Updates generation source and emitter metadata. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2cd0ad1-d514-4a7e-8d0a-1cc7af31aa6c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2cd0ad1-d514-4a7e-8d0a-1cc7af31aa6c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2cd0ad1-d514-4a7e-8d0a-1cc7af31aa6c
✅ Live Test ResultsSummary: 4 passed, 4 warnings in 60.53s (0:01:00) |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (6)
sdk/storage/azure-mgmt-storagesync/tests/test_storage_sync_mgmt_operations_test.py:26
- This assertion is always true, so an empty response would still pass even though an ARM provider must advertise operations. Assert that
resultis non-empty so the test detects an empty or incorrectly deserialized response.
result = [r for r in response]
assert len(result) >= 0
sdk/storage/azure-mgmt-storagesync/tests/test_storage_sync_mgmt_operations_async_test.py:27
- This assertion is always true, so an empty response would still pass even though an ARM provider must advertise operations. Assert that
resultis non-empty so the async path detects an empty or incorrectly deserialized response.
result = [r async for r in response]
assert len(result) >= 0
sdk/storage/azure-mgmt-storagesync/tests/test_storage_sync_mgmt_storage_sync_services_operations_test.py:23
- This subscription-scoped call does not use
resource_group, but the preparer creates and deletes a real resource group on every live run. That adds contributor-permission requirements and an unrelated provisioning failure mode; remove the preparer and unused parameter. The same no-resource setup is used for the operations smoke test atsdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_operations.py:31-35.
@RandomNameResourceGroupPreparer(location=AZURE_LOCATION)
@recorded_by_proxy
def test_storage_sync_services_list_by_subscription(self, resource_group):
sdk/storage/azure-mgmt-storagesync/tests/test_storage_sync_mgmt_storage_sync_services_operations_async_test.py:24
- This subscription-scoped call does not use
resource_group, but the preparer creates and deletes a real resource group on every live run. That adds contributor-permission requirements and an unrelated provisioning failure mode; remove the preparer and unused parameter.
@RandomNameResourceGroupPreparer(location=AZURE_LOCATION)
@recorded_by_proxy_async
async def test_storage_sync_services_list_by_subscription(self, resource_group):
sdk/storage/azure-mgmt-storagesync/tests/test_storage_sync_mgmt_operations_async_test.py:24
operations.list()needs no resource group, but this preparer provisions and deletes one for every live run. This adds contributor-permission requirements and an unrelated Azure provisioning failure mode; remove the preparer and unused parameter.
This issue also appears on line 26 of the same file.
@RandomNameResourceGroupPreparer(location=AZURE_LOCATION)
@recorded_by_proxy_async
async def test_operations_list(self, resource_group):
sdk/storage/azure-mgmt-storagesync/tests/test_storage_sync_mgmt_operations_test.py:23
operations.list()needs no resource group, but this preparer provisions and deletes one for every live run. This adds contributor-permission requirements and an unrelated Azure provisioning failure mode; remove the preparer and unused parameter, as done insdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_operations.py:31-35.
This issue also appears on line 25 of the same file.
@RandomNameResourceGroupPreparer(location=AZURE_LOCATION)
@recorded_by_proxy
def test_operations_list(self, resource_group):
Configurations: 'specification/storagesync/resource-manager/Microsoft.StorageSync/StorageSync/tspconfig.yaml', API Version: 2022-09-01, SDK Release Type: stable, and CommitSHA: '801a60cdad2669e8f824fedfbabbfe7f7093b940' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6632047 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.