Skip to content

Fix azure-appconfiguration linting for pylint 4.0.6 #48266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ali Satwat Khan (alisatwat3) wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix azure-appconfiguration linting for pylint 4.0.6 #48266

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4888c56
Fix azure-appconfiguration linting for pylint 4.0.6
alisatwat3 Jul 26, 2026
37e3cc7
Potential fix for pull request updating docstring
alisatwat3 Jul 26, 2026
da94568
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Jul 27, 2026
466dc20
Merge remote-tracking branch 'upstream/main' into fix/azure-appconfig…
alisatwat3 Jul 29, 2026
fd2fb97
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Jul 30, 2026
67b804d
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Jul 30, 2026
24c4c4b
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Jul 30, 2026
5400343
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Jul 30, 2026
e8ae7c2
Remove per-test Pylint suppressions
alisatwat3 Jul 30, 2026
6a1bb20
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Aug 2, 2026
c4ed4be
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Aug 3, 2026
28cb336
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Aug 3, 2026
a2bb662
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Aug 3, 2026
7b86d7f
Merge branch 'main' into fix/azure-appconfiguration-pylint-4.0.6
alisatwat3 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...iguration/azure-appconfiguration/azure/appconfiguration/_azure_appconfiguration_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
from ._audience_error_handling_policy import AudienceErrorHandlingPolicy


class AzureAppConfigurationClient:
class AzureAppConfigurationClient: # pylint: disable=docstring-keyword-should-match-keyword-only
"""Represents a client that calls restful API of Azure App Configuration service.

:param str base_url: Base url of the service.
Expand Down
2 changes: 1 addition & 1 deletion ...azure-appconfiguration/azure/appconfiguration/aio/_azure_appconfiguration_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
from .._audience_error_handling_policy import AudienceErrorHandlingPolicy


class AzureAppConfigurationClient:
class AzureAppConfigurationClient: # pylint: disable=docstring-keyword-should-match-keyword-only
"""Represents a client that calls restful API of Azure App Configuration service.

:param str base_url: Base url of the service.
Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-appconfiguration/tests/test_audience.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# license information.
# --------------------------------------------------------------------------

from azure.appconfiguration._audience import get_audience
from azure.appconfiguration._audience import get_audience # pylint: disable=no-cross-package-private-import

# Expected scope constants
_EXPECTED_PUBLIC_CLOUD_AUDIENCE = "https://appconfig.azure.com/"
Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-appconfiguration/tests/test_audience_error_handling_live.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from testcase import AppConfigTestCase
from consts import APPCONFIGURATION_ENDPOINT_STRING
from devtools_testutils import EnvironmentVariableLoader, recorded_by_proxy
from azure.appconfiguration._audience_error_handling_policy import (
from azure.appconfiguration._audience_error_handling_policy import ( # pylint: disable=no-cross-package-private-import

@mrm9084 Matthew Metcalf (mrm9084) Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the correct way to fix this. I've already created an issue to have tests/samples ignore some of these warning. #48308

@alisatwat3 Ali Satwat Khan (alisatwat3) Jul 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the correct approach? Matthew Metcalf (@mrm9084)

AudienceErrorHandlingPolicy,
)

Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-appconfiguration/tests/test_audience_error_handling_live_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from consts import APPCONFIGURATION_ENDPOINT_STRING
from devtools_testutils import EnvironmentVariableLoader
from devtools_testutils.aio import recorded_by_proxy_async
from azure.appconfiguration._audience_error_handling_policy import (
from azure.appconfiguration._audience_error_handling_policy import ( # pylint: disable=no-cross-package-private-import
AudienceErrorHandlingPolicy,
)

Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-appconfiguration/tests/test_audience_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# -------------------------------------------------------------------------
import pytest
from azure.core.exceptions import ClientAuthenticationError
from azure.appconfiguration._audience_error_handling_policy import (
from azure.appconfiguration._audience_error_handling_policy import ( # pylint: disable=no-cross-package-private-import
AudienceErrorHandlingPolicy,
AAD_AUDIENCE_ERROR_CODE,
NO_AUDIENCE_ERROR_MESSAGE,
Expand Down
4 changes: 3 additions & 1 deletion sdk/appconfiguration/azure-appconfiguration/tests/test_azure_appconfiguration_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,9 @@ def send(self, request: PipelineRequest, **kwargs) -> PipelineResponse:
def new_method(request):
request.http_request.headers["Authorization"] = str(uuid4())

from azure.appconfiguration._azure_appconfiguration_requests import AppConfigRequestsCredentialsPolicy
from azure.appconfiguration._azure_appconfiguration_requests import ( # pylint: disable=no-cross-package-private-import
AppConfigRequestsCredentialsPolicy,
)

# Store the method to restore later
temp = AppConfigRequestsCredentialsPolicy._signed_request
Expand Down
4 changes: 3 additions & 1 deletion ...appconfiguration/azure-appconfiguration/tests/test_azure_appconfiguration_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,7 +1372,9 @@ async def send(self, request: PipelineRequest, **kwargs) -> PipelineResponse:
def new_method(request):
request.http_request.headers["Authorization"] = str(uuid4())

from azure.appconfiguration._azure_appconfiguration_requests import AppConfigRequestsCredentialsPolicy
from azure.appconfiguration._azure_appconfiguration_requests import ( # pylint: disable=no-cross-package-private-import
AppConfigRequestsCredentialsPolicy,
)

# Store the method to restore later
temp = AppConfigRequestsCredentialsPolicy._signed_request
Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-appconfiguration/tests/test_consistency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
SecretReferenceConfigurationSetting,
FILTER_PERCENTAGE,
)
from azure.appconfiguration._generated.models import (
from azure.appconfiguration._generated.models import ( # pylint: disable=no-cross-package-private-import
KeyValue,
KeyValueFilter,
Snapshot as GeneratedSnapshot,
Expand Down
4 changes: 2 additions & 2 deletions sdk/appconfiguration/azure-appconfiguration/tests/test_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
from azure.core.credentials import AzureKeyCredential
from azure.core.pipeline.transport import HttpRequest
from azure.core.pipeline import PipelineRequest
from azure.appconfiguration._azure_appconfiguration_requests import (
from azure.appconfiguration._azure_appconfiguration_requests import ( # pylint: disable=no-cross-package-private-import
AppConfigRequestsCredentialsPolicy,
)
from azure.appconfiguration._utils import parse_connection_string
from azure.appconfiguration._utils import parse_connection_string # pylint: disable=no-cross-package-private-import


def test_parse_connection_string_returns_http_endpoint():
Expand Down
4 changes: 3 additions & 1 deletion sdk/appconfiguration/azure-appconfiguration/tests/test_query_param_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
import pytest
from azure.core.pipeline.transport import HttpRequest
from azure.core.pipeline import PipelineRequest
from azure.appconfiguration._query_param_policy import QueryParamPolicy
from azure.appconfiguration._query_param_policy import ( # pylint: disable=no-cross-package-private-import
QueryParamPolicy,
)

TEST_URL = "https://example.com"

Expand Down
5 changes: 4 additions & 1 deletion sdk/appconfiguration/azure-appconfiguration/tests/test_sync_token_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@

from azure.core.pipeline.transport import HttpRequest, HttpResponse
from azure.core.pipeline import PipelineRequest, PipelineResponse
from azure.appconfiguration._sync_token import SyncToken, SyncTokenPolicy
from azure.appconfiguration._sync_token import ( # pylint: disable=no-cross-package-private-import
SyncToken,
SyncTokenPolicy,
)


def test_parse_sync_token():
Expand Down
Loading