[AutoPR azure-mgmt-keyvault]-generated-from-SDK Generation - Python-6599281#48170
[AutoPR azure-mgmt-keyvault]-generated-from-SDK Generation - Python-6599281#48170azure-sdk-automation[bot] wants to merge 8 commits into
Conversation
…yVault/KeyVault/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: 'f424df09b6cb4874f4c9dfcd0b9debf352a29b77' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6593749 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the azure-mgmt-keyvault Python management SDK to a newer Key Vault ARM spec preview, adds new token binding types/models, and refreshes generated code + metadata accordingly.
Changes:
- Bumped ARM API version defaults to
2026-03-01-previewand refreshed generated operations/samples/tests. - Introduced new token binding types/models/enums and updated existing enums (e.g.,
JsonWebKeyType). - Raised minimum supported Python version to 3.10 and updated package metadata / versioning to
15.0.0.
Reviewed changes
Copilot reviewed 71 out of 72 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/keyvault/azure-mgmt-keyvault/tsp-location.yaml | Updates the azure-rest-api-specs commit pointer used for generation. |
| sdk/keyvault/azure-mgmt-keyvault/pyproject.toml | Updates supported Python versions and required-python floor. |
| sdk/keyvault/azure-mgmt-keyvault/generated_tests/test_key_vault_management_vaults_operations_async.py | Updates generated async tests to include tokenBindingParameters. |
| sdk/keyvault/azure-mgmt-keyvault/generated_tests/test_key_vault_management_vaults_operations.py | Updates generated sync tests to include tokenBindingParameters. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/update_vault.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/update_secret.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/update_access_policies_add.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/put_private_endpoint_connection.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/purge_deleted_vault.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_update.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_put_private_endpoint_connection.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_list_regions_by_resource.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_list_private_link_resources.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_list_private_endpoint_connections_by_resource.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_list_keys.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_list_key_versions.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_list_by_subscription.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_list_by_resource_group.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_get_private_endpoint_connection.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_get_key_version.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_get_key.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_get.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_delete_private_endpoint_connection.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_delete.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_create_or_update.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_create_key.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/managed_hsm_check_mhsm_name_availability.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_vault_by_subscription.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_vault_by_resource_group.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_vault.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_secrets.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_private_link_resources.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_private_endpoint_connection.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_operations.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_keys.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_key_versions.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/list_deleted_vaults.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/get_vault.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/get_secret.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/get_private_endpoint_connection.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/get_key_version.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/get_key.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/get_deleted_vault.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/deleted_managed_hsm_purge.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/deleted_managed_hsm_list.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/deleted_managed_hsm_get.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/delete_vault.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/delete_private_endpoint_connection.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/create_vault_with_network_acls.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/create_vault.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/create_secret.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/create_key.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/generated_samples/check_vault_name_availability.py | Updates sample’s original swagger file reference to preview API version. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/types.py | Adds new generated TypedDict request/response “types” surface. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/operations/_operations.py | Switches default API version to preview and updates signatures to accept _types.* shapes. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/models/_models.py | Adds token binding model + updates existing model docs/types. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/models/_enums.py | Adds/updates enums, including token binding and oct-HSM. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/models/init.py | Re-exports new models/enums and updates renamed enum export. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/aio/operations/_operations.py | Async operations updated similarly (preview api-version + _types.* support). |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/aio/_configuration.py | Default API version updated to preview and docstring updated. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/aio/_client.py | Updates Self import strategy for Python versions. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/_version.py | Bumps package version to 15.0.0. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/_utils/serialization.py | Adds duration numeric formats + fast-path scalar deserialization. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/_utils/model_base.py | Adds duration numeric support, XML deserialization perf improvements, and rest_field enhancements. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/_configuration.py | Default API version updated to preview and docstring updated. |
| sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/_client.py | Updates Self import strategy for Python versions. |
| sdk/keyvault/azure-mgmt-keyvault/apiview-properties.json | Registers new models/enums and updates renamed enum mapping. |
| sdk/keyvault/azure-mgmt-keyvault/api.metadata.yml | Adds new generation metadata (parser/python versions + hash). |
| sdk/keyvault/azure-mgmt-keyvault/_metadata.json | Updates apiVersion/spec commit/emitter and adds http client version metadata. |
| sdk/keyvault/azure-mgmt-keyvault/README.md | Updates supported Python version statements and Entra naming. |
| sdk/keyvault/azure-mgmt-keyvault/CHANGELOG.md | Adds 15.0.0 entry describing new features and breaking change. |
Comments suppressed due to low confidence (1)
sdk/keyvault/azure-mgmt-keyvault/pyproject.toml:1
- The Trove classifier
Programming Language :: Python :: 3.14is not a Python version I’m aware of, and may cause packaging/metadata validation issues on release. Consider removing the 3.14 classifier until Python 3.14 is officially supported, or aligning classifiers strictly with versions you actually test/support.
This comment has been minimized.
This comment has been minimized.
…yVault/KeyVault/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '7b08703f0340226430bd8838aad0d7ac4ab5a665' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6599075 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 78 out of 79 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (2)
sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/_client.py:87
- This says the default is
None, but the regenerated configuration assigns"2026-03-01-preview"whenapi_versionis omitted. Correct the documented default so callers know which service API the client uses.
:keyword api_version: The API version to use for this operation. Known values are
"2026-03-01-preview" and None. Default value is None. If not set, the operation's default API
version will be used. Note that overriding this default value may result in unsupported
behavior.
sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/aio/_client.py:88
- This says the default is
None, but the regenerated configuration assigns"2026-03-01-preview"whenapi_versionis omitted. Correct the documented default so callers know which service API the async client uses.
:keyword api_version: The API version to use for this operation. Known values are
"2026-03-01-preview" and None. Default value is None. If not set, the operation's default API
version will be used. Note that overriding this default value may result in unsupported
behavior.
…yVault/KeyVault/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '7b08703f0340226430bd8838aad0d7ac4ab5a665' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6599281 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 78 out of 79 changed files in this pull request and generated 8 comments.
Comments suppressed due to low confidence (2)
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_vaults_operations_test.py:1
resource_groupis injected/created but never used in this test. This adds unnecessary ARM resource group creation and test runtime/cost. Either remove theRandomNameResourceGroupPreparerdecorator +resource_groupparameter, or use the resource group in the scenario (e.g., create a vault in it) so the precondition is meaningful.
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_managed_hsms_operations_test.py:1resource_groupis created but not used, which increases live test overhead. Consider removing theRandomNameResourceGroupPreparer/resource_groupparameter for list-by-subscription tests, or explicitly create a managed HSM in that resource group so the test is deterministic and the preparer is justified.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 78 out of 79 changed files in this pull request and generated 8 comments.
Comments suppressed due to low confidence (5)
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_vaults_operations_test.py:1
- These live tests assert the subscription has at least one vault and at least one deleted vault, but the test setup does not create/delete any vaults. This makes the suite non-deterministic (and likely to fail in clean subscriptions). To make the tests reliable, either (a) provision a vault and then delete it within the test before calling
list_deleted, and ensure at least one vault exists forlist_by_subscription, or (b) relax assertions to validate response shape/iterability without requiring non-empty results.
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_vaults_operations_test.py:1 - These live tests assert the subscription has at least one vault and at least one deleted vault, but the test setup does not create/delete any vaults. This makes the suite non-deterministic (and likely to fail in clean subscriptions). To make the tests reliable, either (a) provision a vault and then delete it within the test before calling
list_deleted, and ensure at least one vault exists forlist_by_subscription, or (b) relax assertions to validate response shape/iterability without requiring non-empty results.
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_managed_hsms_operations_test.py:1 - Same non-determinism as the vault tests: asserting non-empty results without creating/deleting a Managed HSM makes these live tests brittle. Consider creating and deleting a Managed HSM in-test (if feasible), or change the assertions to not require non-empty lists.
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_managed_hsms_operations_test.py:1 - Same non-determinism as the vault tests: asserting non-empty results without creating/deleting a Managed HSM makes these live tests brittle. Consider creating and deleting a Managed HSM in-test (if feasible), or change the assertions to not require non-empty lists.
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_vaults_operations_test.py:1 - The previous
test_list_customized_api_versionthat validated the legacy paging behavior (ensuringapi-versionis correctly handled acrossnextLinkrequests) was removed. Given the paging logic changed in operations, it would be valuable to retain a regression test that explicitly validatesapi-versionhandling for paged list operations (especially where the service dictates anapi-versionin thenextLink).
[Pilot] PR Pipeline Failure AnalysisA CI pipeline failed on this pull request. Here is an automated analysis of what went wrong and how to get the build green. What failedTwo unit tests in
The uniform failure across all environments strongly suggests a test failure caused by a code/API change in this PR — likely the API version used in vault list operations changed and the unit tests assert on a specific version string that no longer matches. Recommended next steps
Raw pipeline analysis (azsdk ci analyze)
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 78 out of 80 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/_client.py:86
- The documented default is incorrect. When
api_versionis omitted,KeyVaultManagementClientConfigurationsets it to"2026-03-01-preview", notNone; consumers reading this public client docstring will be misled about which API is used. Update this text to match the runtime default.
:keyword api_version: The API version to use for this operation. Known values are
"2026-03-01-preview" and None. Default value is None. If not set, the operation's default API
version will be used. Note that overriding this default value may result in unsupported
sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/aio/_client.py:87
- The documented default is incorrect. When
api_versionis omitted,KeyVaultManagementClientConfigurationsets it to"2026-03-01-preview", notNone; consumers reading this public async-client docstring will be misled about which API is used. Update this text to match the runtime default.
:keyword api_version: The API version to use for this operation. Known values are
"2026-03-01-preview" and None. Default value is None. If not set, the operation's default API
version will be used. Note that overriding this default value may result in unsupported
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 78 out of 80 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (5)
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_vaults_operations_test.py:1
- These assertions require the subscription to already contain (and have deleted) vaults, which is not guaranteed in live runs. To avoid flaky live tests, either (a) create a vault (and delete it for
list_deleted) within the test and assert it appears in the list, or (b) change the assertion to only validate that iteration succeeds (e.g., no exception) and/or that the result is a list, without requiring non-empty results.
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_vaults_operations_test.py:1 - These assertions require the subscription to already contain (and have deleted) vaults, which is not guaranteed in live runs. To avoid flaky live tests, either (a) create a vault (and delete it for
list_deleted) within the test and assert it appears in the list, or (b) change the assertion to only validate that iteration succeeds (e.g., no exception) and/or that the result is a list, without requiring non-empty results.
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_managed_hsms_operations_test.py:1 - Similar to the vault list tests, these assume the subscription already has Managed HSM resources and deleted Managed HSMs. That makes live runs brittle. Prefer creating a Managed HSM (and deleting it for the deleted-list test) as part of the test, or relax assertions to verify call/iteration succeeds without requiring a non-empty result.
sdk/keyvault/azure-mgmt-keyvault/tests/test_key_vault_management_managed_hsms_operations_test.py:1 - Similar to the vault list tests, these assume the subscription already has Managed HSM resources and deleted Managed HSMs. That makes live runs brittle. Prefer creating a Managed HSM (and deleting it for the deleted-list test) as part of the test, or relax assertions to verify call/iteration succeeds without requiring a non-empty result.
sdk/keyvault/azure-mgmt-keyvault/pyproject.toml:1 - The Trove classifier
Programming Language :: Python :: 3.14may not be recognized by PyPI tooling unless/ until that classifier exists. Consider removing it (or only adding it once the official classifier is available). Also, sincerequires-pythonis raised to>=3.10, ensure this breaking change is explicitly captured inCHANGELOG.mdunder Breaking Changes.
Configurations: 'specification/keyvault/resource-manager/Microsoft.KeyVault/KeyVault/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '7b08703f0340226430bd8838aad0d7ac4ab5a665' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6599281 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan information is not available. Create a release plan and link SDK pull request to the release plan. Refer aka.ms/azsdk/releaseplan-dashboard for more info.