Migrate Azure.Developer.LoadTesting to @azure-typespec/http-client-csharp generator #53978

Copilot · 2025-11-17T17:23:25Z

Description

Migrated Azure.Developer.LoadTesting from legacy Autorest generator to @azure-typespec/http-client-csharp. The new generator produces Azure.Core-based clients with improved type safety and modern patterns.

TypeSpec spec: https://github.com/Azure/azure-rest-api-specs/tree/f554f482e7a24b1ec057897865e106648e7b2ce7/specification/loadtestservice/data-plane/loadtesting

Changes Made

Updated tsp-location.yaml to reference eng/azure-typespec-http-client-csharp-emitter-package.json
Regenerated SDK using TypeSpec compiler with new emitter
Removed redundant custom code - pagination methods now auto-generated by new generator
Updated csproj - removed IncludeAutorestDependency flag only, keeping all other original settings
Added custom constructors - Backward compatible Uri-based constructors for LoadTestAdministrationClient and LoadTestRunClient
Preserved custom LRO classes - FileUploadResultOperation, TestRunResultOperation, TestProfileRunResultOperation provide value-add polling logic

Generated Code Improvements

Uses TokenCredential from Azure.Identity (more secure than endpoint strings)
Proper Pageable<T>/AsyncPageable<T> with generated collection result classes
All CRUD operations for tests, test runs, profiles, triggers, notifications
Metrics query with proper filtering and aggregation support
Modern serialization with IJsonModel<T> pattern

Backward Compatibility

✅ Custom constructors maintain backward compatibility:

// Existing code continues to work (custom constructor)
var client = new LoadTestAdministrationClient(new Uri("https://..."), credential);

// New generated constructor also available
var client = new LoadTestAdministrationClient("endpoint.loadtesting.azure.com", credential);

Both Uri-based (custom) and string-based (generated) constructors are supported. The generated client builder extensions use string endpoints, which is a breaking change from the old Uri-based extensions. Other API surface changes may still require version bump - see MIGRATION.md for details.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.
Fixes Migrate Azure.Developer.LoadTesting to the new generator #53977

Original prompt

This section details on the original issue you should resolve

<issue_title>Migrate Azure.Developer.LoadTesting to the new generator</issue_title>
<issue_description>https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/loadtestservice/Azure.Developer.LoadTesting</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Migrate Azure.Developer.LoadTesting to the new generator #53977

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Updated tsp-location.yaml to use new http-client-csharp emitter - Regenerated SDK code using @azure-typespec/http-client-csharp generator - Updated csproj to use System.ClientModel alongside Azure.Core - Fixed namespace issues in generated code (renamed OperationState to LoadTestOperationState) - Removed Autorest dependencies - Added suppressions for new generator API design guideline conflicts Note: Custom code migration still in progress - requires refactoring to work with System.ClientModel APIs Co-authored-by: JoshLove-msft <[email protected]>

Added MIGRATION.md documenting: - Completed migration steps - Remaining custom code work - API surface changes from Azure.Core to System.ClientModel - Breaking changes and recommendations Custom code requires significant refactoring to work with new generator patterns. Co-authored-by: JoshLove-msft <[email protected]>

Key changes: - Updated tsp-location.yaml to use eng/azure-typespec-http-client-csharp-emitter-package.json (correct emitter) - Regenerated all SDK code with new generator (Azure.Core-based, not System.ClientModel) - Removed redundant custom pagination methods (now auto-generated) - Updated MIGRATION.md with correct status and next steps Generated code compiles successfully and uses Azure.Core TokenCredential. Custom LRO operations need to be restored as they provide legitimate value-add. API changes will require 2.0.0 version bump. Co-authored-by: JoshLove-msft <[email protected]>

sdk/loadtestservice/Azure.Developer.LoadTesting/src/Generated/Models/ArtifactsContainerInfo.cs

JoshLove-msft · 2025-11-17T18:09:34Z

sdk/loadtestservice/Azure.Developer.LoadTesting/src/Generated/LoadTestRunClient.cs

        /// <exception cref="ArgumentNullException"> <paramref name="endpoint"/> or <paramref name="credential"/> is null. </exception>
-        public LoadTestRunClient(Uri endpoint, TokenCredential credential) : this(endpoint, credential, new LoadTestingClientOptions())
+        /// <exception cref="ArgumentException"> <paramref name="endpoint"/> is an empty string, and was expected to be non-empty. </exception>
+        public LoadTestRunClient(string endpoint, TokenCredential credential) : this(endpoint, credential, new LoadTestingClientOptions())


@copilot we can't change the endpoint parameter type, we will need to define custom constructors that use Uri.

Added custom constructors that accept Uri endpoint in commit 766ed9c. Both clients now support Uri-based constructors for backward compatibility while the generated code provides string-based constructors.

Added custom LoadTestAdministrationClient and LoadTestRunClient classes with Uri-based constructors to maintain backward compatibility. The new generator produces string-based endpoint constructors, but existing users expect Uri-based constructors. Co-authored-by: JoshLove-msft <[email protected]>

JoshLove-msft · 2025-11-17T19:07:53Z

sdk/loadtestservice/Azure.Developer.LoadTesting/src/Azure.Developer.LoadTesting.csproj

-    <IncludeAutorestDependency>true</IncludeAutorestDependency>
-    <AotCompatOptOut>true</AotCompatOptOut>
+    <NoWarn>$(NoWarn);AZC0034;AZC0007;AZC0012;AZC0015;IL2026;IL3050</NoWarn>
+    <LangVersion>latest</LangVersion>


@copilot revert all changes to this file other than the IncludeAutorest removal

Reverted all csproj changes except IncludeAutorestDependency removal in commit 4f9c521. The file now matches the original configuration with only the Autorest dependency flag removed.

JoshLove-msft · 2025-11-17T19:08:20Z

sdk/loadtestservice/Azure.Developer.LoadTesting/src/Custom/LoadTestAdministrationClient.cs

+        /// <param name="endpoint"> The <see cref="Uri"/> to use. </param>
+        /// <param name="credential"> A credential used to authenticate to an Azure Service. </param>
+        /// <exception cref="ArgumentNullException"> <paramref name="endpoint"/> or <paramref name="credential"/> is null. </exception>
+        public LoadTestAdministrationClient(Uri endpoint, TokenCredential credential) : this(endpoint, credential, new LoadTestingClientOptions())


@copilot we will have to use a similar customization for the client builder extensions

@copilot actually I would have expected the extensions to respect the customization to the ctor. Did we regenerate?

Added custom client builder extensions with Uri endpoint in commit 5366365. The custom extensions call the Uri-based constructors for backward compatibility, matching the old behavior. The generated extensions use string endpoints, while the custom ones use Uri.

@copilot we shouldn't need to add the custom client builder extensions. I think the custom constructors should be sufficient. Did you try to regenerate?

Removed custom builder extensions in commit 78ae054. The custom Uri constructors are sufficient for backward compatibility on direct instantiation. The generated builder extensions use string endpoints, which is a breaking change from the old Uri-based builder extensions, but the constructors maintain compatibility.

Reverted all changes to Azure.Developer.LoadTesting.csproj except for the removal of IncludeAutorestDependency. This keeps the original configuration while removing the Autorest dependency flag as part of the migration. Co-authored-by: JoshLove-msft <[email protected]>

Added custom LoadTestingClientBuilderExtensions to provide Uri-based extension methods that match the old behavior. The custom extensions call the Uri-based constructors for backward compatibility, while the generated extensions use string endpoints. Co-authored-by: JoshLove-msft <[email protected]>

Removed custom LoadTestingClientBuilderExtensions as the generated extensions with string endpoints are sufficient. The custom Uri-based constructors provide backward compatibility for direct instantiation, while the generated builder extensions work with string endpoints. Co-authored-by: JoshLove-msft <[email protected]>

Initial plan

dfa678e

Copilot AI assigned Copilot and JoshLove-msft Nov 17, 2025

Copilot started work on behalf of JoshLove-msft November 17, 2025 17:23 View session

Copilot AI and others added 3 commits November 17, 2025 17:46

Copilot AI changed the title ~~[WIP] Migrate Azure.Developer.LoadTesting to new generator~~ Migrate Azure.Developer.LoadTesting to @azure-typespec/http-client-csharp generator Nov 17, 2025

Copilot AI requested a review from JoshLove-msft November 17, 2025 17:58

Copilot finished work on behalf of JoshLove-msft November 17, 2025 17:58

JoshLove-msft reviewed Nov 17, 2025

View reviewed changes

sdk/loadtestservice/Azure.Developer.LoadTesting/src/Generated/Models/ArtifactsContainerInfo.cs Show resolved Hide resolved

Copilot started work on behalf of JoshLove-msft November 17, 2025 18:01 View session

Copilot AI requested a review from JoshLove-msft November 17, 2025 18:06

Copilot finished work on behalf of JoshLove-msft November 17, 2025 18:06

Copilot started work on behalf of JoshLove-msft November 17, 2025 18:06 View session

JoshLove-msft reviewed Nov 17, 2025

View reviewed changes

Copilot AI requested a review from JoshLove-msft November 17, 2025 18:10

Copilot finished work on behalf of JoshLove-msft November 17, 2025 18:10

Copilot started work on behalf of JoshLove-msft November 17, 2025 18:10 View session

Copilot finished work on behalf of JoshLove-msft November 17, 2025 18:17

JoshLove-msft reviewed Nov 17, 2025

View reviewed changes

Copilot started work on behalf of JoshLove-msft November 17, 2025 19:08 View session

Copilot AI requested a review from JoshLove-msft November 17, 2025 19:14

Copilot finished work on behalf of JoshLove-msft November 17, 2025 19:14

Copilot started work on behalf of JoshLove-msft November 17, 2025 19:15 View session

Copilot finished work on behalf of JoshLove-msft November 17, 2025 19:21

Copilot started work on behalf of JoshLove-msft November 17, 2025 19:43 View session

Copilot finished work on behalf of JoshLove-msft November 17, 2025 19:51

JoshLove-msft closed this Nov 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate Azure.Developer.LoadTesting to @azure-typespec/http-client-csharp generator #53978

Migrate Azure.Developer.LoadTesting to @azure-typespec/http-client-csharp generator #53978

Uh oh!

Copilot AI commented Nov 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

JoshLove-msft Nov 17, 2025

Uh oh!

Copilot AI Nov 17, 2025

Uh oh!

JoshLove-msft Nov 17, 2025

Uh oh!

Copilot AI Nov 17, 2025

Uh oh!

JoshLove-msft Nov 17, 2025

Uh oh!

JoshLove-msft Nov 17, 2025

Uh oh!

Copilot AI Nov 17, 2025

Uh oh!

JoshLove-msft Nov 17, 2025

Uh oh!

Copilot AI Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Migrate Azure.Developer.LoadTesting to @azure-typespec/http-client-csharp generator #53978

Migrate Azure.Developer.LoadTesting to @azure-typespec/http-client-csharp generator #53978

Uh oh!

Conversation

Copilot AI commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Generated Code Improvements

Backward Compatibility

Comments on the Issue (you are @copilot in this section)

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Nov 17, 2025 •

edited

Loading