Changes required for testing upgrades to cspell #53947
Merged
+43
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
requested review from
benbp,
hallipr,
jsquire and
weshaggard
as code owners
Copilot finished reviewing on behalf of
danieljurek
November 15, 2025 00:00
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces changes to support testing upgrades to cspell (the spell checking tool) across the Azure SDK repository. The changes include adding a new spell check script for public API surfaces, adding cspell configuration for the recoveryservices SDK, and enabling cspell upgrade verification in the CI pipeline.
Key Changes
- New PowerShell script (
spell-check-public-api.ps1) to spell check all public API surface files - Added cspell configuration for the recoveryservices SDK to whitelist the "bcdr" term
- Enabled
EnableCspellUpgradeVerificationparameter in the CI pipeline's spell check step
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/scripts/spell-check-public-api.ps1 | New script to perform spell checking on all public API surface files (*.cs files in api/ directories) |
| sdk/recoveryservices/cspell.yaml | New cspell configuration file that whitelists "bcdr" term for the recoveryservices SDK |
| eng/pipelines/templates/jobs/ci.yml | Adds EnableCspellUpgradeVerification parameter to the spell checking step for testing cspell upgrades |
weshaggard
reviewed
Nov 17, 2025
weshaggard
reviewed
Nov 17, 2025
weshaggard
reviewed
Nov 17, 2025
weshaggard
reviewed
Nov 18, 2025
danieljurek
force-pushed
the
djurek/spell-check-upgrade-support
branch
from
2fcdf3c to
a45d38f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Azure/azure-sdk-tools#12910